Check Dart formatting in all packages and in tool/ (#9873)

* Check formatting in all packages and in tool/

* feedback

* format

Author: srawlins

packages/devtools_shared/lib/src/server/handlers/_devtools_extensions.dart

@@ -90,7 +90,8 @@ extension _ExtensionsApiHandler on Never {
     // separators, so the check holds for Windows file URIs as well. Requiring
     // an empty host rejects UNC paths (e.g. `file://server/share/...`) and
     // keeps `toFilePath()` from throwing on a non-local authority.
-    final isFileUri = devtoolsOptionsFileUri.scheme == 'file' &&
+    final isFileUri =
+        devtoolsOptionsFileUri.scheme == 'file' &&
         devtoolsOptionsFileUri.host.isEmpty;
     final fileName = isFileUri
         ? p.basename(devtoolsOptionsFileUri.toFilePath())

tool/ci/bots.sh

@@ -15,10 +15,9 @@ echo `pwd`
 
 if [ "$BOT" = "main" ]; then
 
-    # Verify that dart format has been run.
     echo "Checking formatting..."
-    # Here, we use the dart instance from the flutter sdk.
-    $(dirname $(which flutter))/dart format --output=none --set-exit-if-changed .
+    # Here, we use the dart instance from the flutter SDK.
+    dart format --output=none --set-exit-if-changed .
 
     # Make sure the app versions are in sync.
     dt repo-check

tool/ci/package_tests.sh

@@ -13,13 +13,25 @@ if [ "$PACKAGE" = "devtools_app_shared" ]; then
 
     pushd $DEVTOOLS_DIR/packages/devtools_app_shared
     echo `pwd`
+
+    echo "Checking formatting..."
+    # Here, we use the dart instance from the flutter SDK.
+    dart format --output=none --set-exit-if-changed .
+
     flutter test test/
     popd
 
 elif [ "$PACKAGE" = "devtools_extensions" ]; then
 
     pushd $DEVTOOLS_DIR/packages/devtools_extensions
     echo `pwd`
+
+    echo "Checking formatting..."
+    # Here, we use the dart instance from the flutter SDK.
+    dart format --output=none --set-exit-if-changed .
+
+    # Note that this will _not_ test any tests in nested directories, if we add
+    # any.
     flutter test test/*_test.dart
     # Skip this on Windows because `flutter test --platform chrome`
     # appears to hang there.
@@ -33,6 +45,11 @@ elif [ "$PACKAGE" = "devtools_shared" ]; then
 
     pushd $DEVTOOLS_DIR/packages/devtools_shared
     echo `pwd`
+
+    echo "Checking formatting..."
+    # Here, we use the dart instance from the flutter SDK.
+    dart format --output=none --set-exit-if-changed .
+
     dart test test/
     popd
 

tool/ci/tool_tests.sh

@@ -11,5 +11,10 @@ source ./tool/ci/setup.sh
 
 pushd $DEVTOOLS_DIR/tool
 echo `pwd`
+
+echo "Checking formatting..."
+# Here, we use the dart instance from the flutter SDK.
+dart format --output=none --set-exit-if-changed lib/ test/
+
 flutter test test/
-popd
+popd