Consolidate the Disposable logic in devtools_app_shared (#8952)

Author: kenzieschmoll

packages/devtools_app/lib/src/shared/diagnostics/object_group_api.dart

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.
 
-import 'package:devtools_app_shared/service.dart';
+import 'package:devtools_app_shared/utils.dart';
 import 'package:flutter/foundation.dart';
 import 'package:vm_service/vm_service.dart';
 

packages/devtools_app/lib/src/shared/ui/hover.dart

@@ -5,8 +5,8 @@
 import 'dart:async';
 import 'dart:math' as math;
 
-import 'package:devtools_app_shared/service.dart';
 import 'package:devtools_app_shared/ui.dart';
+import 'package:devtools_app_shared/utils.dart';
 import 'package:flutter/gestures.dart';
 import 'package:flutter/material.dart';
 import 'package:provider/provider.dart';

packages/devtools_app/test/shared/eval_integration_test.dart

@@ -4,6 +4,7 @@
 
 import 'package:devtools_app/src/shared/globals.dart';
 import 'package:devtools_app_shared/service.dart';
+import 'package:devtools_app_shared/utils.dart';
 import 'package:devtools_test/helpers.dart';
 import 'package:flutter_test/flutter_test.dart';
 

packages/devtools_app_shared/CHANGELOG.md

@@ -3,9 +3,12 @@ Copyright 2025 The Flutter Authors
 Use of this source code is governed by a BSD-style license that can be
 found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.
 -->
-## 0.3.2 (not released)
+## 0.4.0 (not released)
 * Add `DisposableController.init` method and `DisposableController.disposed`
 getter.
+* Move the `Disposable` class from the 
+`package:devtools_app_shared/service.dart` library to the 
+`package:devtools_app_shared/utils.dart` library.
 
 ## 0.3.1
 * Bump `vm_service` dependency to `>=13.0.0 <16.0.0`.

packages/devtools_app_shared/lib/src/service/eval_on_dart_library.dart

@@ -20,15 +20,6 @@ import 'service_manager.dart';
 
 final _log = Logger('eval_on_dart_library');
 
-class Disposable {
-  bool disposed = false;
-
-  @mustCallSuper
-  void dispose() {
-    disposed = true;
-  }
-}
-
 // TODO(https://github.com/flutter/devtools/issues/6239): try to remove this.
 @sealed
 class EvalOnDartLibrary extends DisposableController

packages/devtools_app_shared/lib/src/service/service_manager.dart

@@ -14,6 +14,7 @@ import 'package:meta/meta.dart';
 import 'package:path/path.dart' as path;
 import 'package:vm_service/vm_service.dart' hide Error;
 
+import '../utils/auto_dispose.dart';
 import '../utils/utils.dart';
 import 'connected_app.dart';
 import 'dtd_manager.dart';

packages/devtools_app_shared/lib/src/utils/auto_dispose.dart

@@ -242,9 +242,12 @@ mixin DisposerMixin {
 }
 
 /// Base class for controllers that need to manage their lifecycle.
-abstract class DisposableController {
+abstract class DisposableController extends Disposable {
   void init() {}
+}
 
+/// Represents a disposable object.
+class Disposable {
   bool get disposed => _disposed;
 
   bool _disposed = false;

packages/devtools_app_shared/pubspec.yaml

@@ -3,7 +3,7 @@
 # found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.
 name: devtools_app_shared
 description: Package of Dart & Flutter structures shared between devtools_app and devtools extensions.
-version: 0.3.2
+version: 0.4.0
 repository: https://github.com/flutter/devtools/tree/master/packages/devtools_app_shared
 
 environment:

packages/devtools_extensions/CHANGELOG.md

@@ -4,7 +4,7 @@ Use of this source code is governed by a BSD-style license that can be
 found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.
 -->
 ## 0.3.2 (not released)
-* Bump `devtools_app_shared` dependency to `0.3.2`.
+* Bump `devtools_app_shared` dependency to `0.4.0`.
 
 ## 0.3.1
 * Bump `vm_service` dependency to `>=13.0.0 <16.0.0`.

packages/devtools_extensions/pubspec.yaml

@@ -19,7 +19,7 @@ executables:
 dependencies:
   args: ^2.4.2
   devtools_shared: ^11.1.0
-  devtools_app_shared: ^0.3.2
+  devtools_app_shared: ^0.4.0
   flutter:
     sdk: flutter
   io: ^1.0.4