Skip to content

Commit f29602d

Browse files
committed
Fix bug and format.
1 parent 64d384c commit f29602d

9 files changed

Lines changed: 13 additions & 29 deletions

File tree

packages/devtools_app/lib/src/extensions/embedded/_controller_web.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ class EmbeddedExtensionControllerImpl extends EmbeddedExtensionController
7878
final extensionPostEventStream =
7979
StreamController<DevToolsExtensionEvent>.broadcast();
8080

81-
// ignore: unused-code, TODO(https://github.com/flutter/devtools/issues/9907): false positive.
81+
// ignore: unused-code, TODO(https://github.com/flutter/devtools/issues/9907): false positive.
8282
bool _initialized = false;
8383

8484
@override

packages/devtools_app/lib/src/screens/accessibility/accessibility_screen.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ class AccessibilityScreenBody extends StatefulWidget {
3434

3535
class _AccessibilityScreenBodyState extends State<AccessibilityScreenBody>
3636
with AutoDisposeMixin {
37-
// ignore: unused-code, temporarily ignore since this screen is under active development.
37+
// ignore: unused-code, temporarily ignore since this screen is under active development.
3838
late AccessibilityController controller;
3939

4040
@override

packages/devtools_app/lib/src/screens/app_size/app_size_screen.dart

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -212,6 +212,7 @@ class _AppSizeBodyState extends State<AppSizeBody>
212212
if (currentTab.key == AppSizeScreen.diffTabKey) ...[
213213
const SizedBox(width: defaultSpacing),
214214
DiffTreeTypeDropdown(
215+
value: controller.activeDiffTreeType.value,
215216
onChanged: (newDiffTreeType) {
216217
controller.changeActiveDiffTreeType(newDiffTreeType!);
217218
},
@@ -278,9 +279,11 @@ class AppUnitDropdown extends StatelessWidget {
278279
class DiffTreeTypeDropdown extends StatelessWidget {
279280
const DiffTreeTypeDropdown({
280281
super.key,
282+
required this.value,
281283
required this.onChanged,
282284
});
283285

286+
final DiffTreeType value;
284287
final ValueChanged<DiffTreeType?>? onChanged;
285288

286289
@override
@@ -289,6 +292,7 @@ class DiffTreeTypeDropdown extends StatelessWidget {
289292
height: defaultButtonHeight,
290293
child: RoundedDropDownButton<DiffTreeType>(
291294
key: AppSizeScreen.diffTypeDropdownKey,
295+
value: value,
292296
isDense: true,
293297
items: [
294298
_buildDiffTreeTypeMenuItem(DiffTreeType.combined),

packages/devtools_app/lib/src/screens/dtd/dtd_tools_model.dart

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,7 @@ abstract class FeatureController extends DisposableController
1818
/// [service] may be null if this service method is a first party service
1919
/// method registered by DTD or by a DTD-internal service.
2020
class DtdServiceMethod implements Comparable<DtdServiceMethod> {
21-
const DtdServiceMethod({
22-
required this.service,
23-
required this.method,
24-
});
21+
const DtdServiceMethod({required this.service, required this.method});
2522

2623
final String? service;
2724
final String method;

packages/devtools_app/lib/src/screens/dtd/services.dart

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -57,10 +57,7 @@ class ServicesController extends FeatureController {
5757
}),
5858
for (final service in response.clientServices) ...[
5959
for (final method in service.methods.values)
60-
DtdServiceMethod(
61-
service: service.name,
62-
method: method.name,
63-
),
60+
DtdServiceMethod(service: service.name, method: method.name),
6461
],
6562
];
6663
}

packages/devtools_app/lib/src/screens/inspector/widget_properties/properties_view.dart

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,7 @@ import '../layout_explorer/flex/flex.dart';
2020
/// Table for the widget's properties, along with its render object and a
2121
/// flex layout explorer if the widget is part of a flex layout.
2222
class DetailsTable extends StatefulWidget {
23-
const DetailsTable({
24-
super.key,
25-
required this.controller,
26-
});
23+
const DetailsTable({super.key, required this.controller});
2724

2825
static const gaPrefix = 'inspectorDetailsTable';
2926

packages/devtools_app/lib/src/screens/network/network_screen.dart

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -319,9 +319,7 @@ class _NetworkProfilerBody extends StatelessWidget {
319319
ValueListenableBuilder<List<NetworkRequest>>(
320320
valueListenable: controller.filteredData,
321321
builder: (context, filteredRequests, _) {
322-
return NetworkRequestsTable(
323-
requests: filteredRequests
324-
);
322+
return NetworkRequestsTable(requests: filteredRequests);
325323
},
326324
),
327325
const NetworkRequestInspector(),
@@ -331,10 +329,7 @@ class _NetworkProfilerBody extends StatelessWidget {
331329
}
332330

333331
class NetworkRequestsTable extends StatelessWidget {
334-
const NetworkRequestsTable({
335-
super.key,
336-
required this.requests,
337-
});
332+
const NetworkRequestsTable({super.key, required this.requests});
338333

339334
static const methodColumn = MethodColumn();
340335
static final addressColumn = AddressColumn();

packages/devtools_app/lib/src/screens/vm_developer/vm_service_private_extensions.dart

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -651,10 +651,7 @@ enum ObjectPoolEntryKind {
651651
}
652652

653653
class ObjectPoolEntry {
654-
const ObjectPoolEntry({
655-
required this.offset,
656-
required this.value,
657-
});
654+
const ObjectPoolEntry({required this.offset, required this.value});
658655

659656
static const _offsetKey = 'offset';
660657
static const _valueKey = 'value';

packages/devtools_app/test/screens/vm_developer/object_inspector/vm_object_pool_display_test.dart

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,7 @@ void main() {
4343
length: 0,
4444
),
4545
),
46-
const ObjectPoolEntry(
47-
offset: 10,
48-
value: 42,
49-
),
46+
const ObjectPoolEntry(offset: 10, value: 42),
5047
ObjectPoolEntry(
5148
offset: 20,
5249
value: FuncRef(id: 'func-id', name: 'Foo'),

0 commit comments

Comments
 (0)