feat: migrate devtools tool skill validation to new dart_skills_lint API

Author: reidbaker

pubspec.lock

@@ -213,11 +213,11 @@ packages:
     dependency: transitive
     description:
       path: "tool/dart_skills_lint"
-      ref: e4497873950727ee781fa411c1a2f624b1ec50c6
-      resolved-ref: e4497873950727ee781fa411c1a2f624b1ec50c6
+      ref: "05e5a45fa412ddbdd1d694eee0c71f4bbaea2617"
+      resolved-ref: "05e5a45fa412ddbdd1d694eee0c71f4bbaea2617"
       url: "https://github.com/flutter/skills"
     source: git
-    version: "0.3.0"
+    version: "0.4.0"
   dart_style:
     dependency: transitive
     description:
@@ -555,10 +555,10 @@ packages:
     dependency: transitive
     description:
       name: meta
-      sha256: c82594181e3312f3d0695fc95aaaf7758d75b8d4ae2bbecf223b9fd5109a059d
+      sha256: "307249ce4ff29d58a18e97f6345f539382eb9c9c29ecda628900f31de0443dd9"
       url: "https://pub.dev"
     source: hosted
-    version: "1.18.3"
+    version: "1.19.0"
   mime:
     dependency: transitive
     description:

tool/cpu_sample_intervals.dart

@@ -26,10 +26,10 @@ void main(List<String> arguments) async {
 
   final List<int> deltas = [];
   for (int i = 0; i < cpuSampleTraceEvents.length - 1; i++) {
-    final Map<String, dynamic> current =
-        (cpuSampleTraceEvents[i] as Map).cast<String, dynamic>();
-    final Map<String, dynamic> next =
-        (cpuSampleTraceEvents[i + 1] as Map).cast<String, dynamic>();
+    final Map<String, dynamic> current = (cpuSampleTraceEvents[i] as Map)
+        .cast<String, dynamic>();
+    final Map<String, dynamic> next = (cpuSampleTraceEvents[i + 1] as Map)
+        .cast<String, dynamic>();
     deltas.add((next['ts'] as int) - (current['ts'] as int));
   }
   print(deltas);

tool/json_to_map.dart

@@ -30,8 +30,9 @@ void main(List<String> args) {
   }
 
   final jsonFileName = jsonFilePath.split('/').last;
-  final fileNameWithoutExtension = (jsonFileName.split('.')
-    ..removeLast()).join('.');
+  final fileNameWithoutExtension = (jsonFileName.split(
+    '.',
+  )..removeLast()).join('.');
   final jsonFileDirectoryPath = Uri.parse(
     (jsonFilePath.split('/')..removeLast()).join('/'),
   );
@@ -45,10 +46,9 @@ void main(List<String> args) {
   // String interpolation.
   jsonFormattedString = jsonFormattedString.replaceAll('\$', '\\\$');
 
-  final dartFile =
-      File('$jsonFileDirectoryPath/$fileNameWithoutExtension.dart')
-        ..createSync()
-        ..writeAsStringSync('''
+  final dartFile = File('$jsonFileDirectoryPath/$fileNameWithoutExtension.dart')
+    ..createSync()
+    ..writeAsStringSync('''
 // Copyright 2023 The Flutter Authors
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file or at https://developers.google.com/open-source/licenses/bsd.

tool/pubspec.yaml

@@ -28,6 +28,6 @@ dev_dependencies:
     git:
       url: https://github.com/flutter/skills
       path: tool/dart_skills_lint
-      ref: e4497873950727ee781fa411c1a2f624b1ec50c6
+      ref: 05e5a45fa412ddbdd1d694eee0c71f4bbaea2617
   logging: ^1.1.1
   test: ^1.25.8

tool/test/validate_skills_test.dart

@@ -4,11 +4,10 @@
 
 import 'dart:async';
 import 'package:dart_skills_lint/dart_skills_lint.dart';
+import 'package:devtools_tool/utils.dart';
 import 'package:logging/logging.dart';
 import 'package:test/test.dart';
 
-const String _configFilePath = 'dart_skills_lint.yaml';
-
 void main() {
   test('Validate DevTools Skills', () async {
     final Level oldLevel = Logger.root.level;
@@ -19,10 +18,23 @@ void main() {
         });
 
     try {
+      final String configFilePath = pathFromRepoRoot(
+        'tool/dart_skills_lint.yaml',
+      );
+      final String skillsDirPath = pathFromRepoRoot('.agents/skills');
+
       final Configuration config = await ConfigParser.loadConfig(
-        path: _configFilePath,
+        path: configFilePath,
+      );
+      final bool isValid = await validateSkills(
+        skillDirPaths: [skillsDirPath],
+        config: config,
+        resolvedRuleConfigs: {
+          'check-absolute-paths': const RuleConfigPatch(
+            severity: AnalysisSeverity.disabled,
+          ),
+        },
       );
-      final bool isValid = await validateSkills(config: config);
       expect(
         isValid,
         isTrue,