Simplify QueryFilter.filterArguments for callers#9069
Merged
srawlins merged 1 commit intoflutter:masterfrom Mar 26, 2025
Merged
Simplify QueryFilter.filterArguments for callers#9069srawlins merged 1 commit intoflutter:masterfrom
srawlins merged 1 commit intoflutter:masterfrom
Conversation
kenzieschmoll
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This CL is a step towards making the "filter" code shareable, as per #7793.
(It's also just a cleanup independent of making code shareable.)
QueryFilter.filterArgumentsjust use the set of QueryFilterArguments; they do not pay any attention to the mapping from filter kinds. So just simplify the API to only expose the set of QueryFilterArguments.FilterControllerMixin.filterTagNotifier.createQueryFilterArgsasvisibleForOverriding._filterArguments, and getter,filterArguments, are not collections ofQueryFilterArgument<dynamic>.