[Property Editor] Better error handling#9101
Merged
elliette merged 4 commits intoflutter:masterfrom Apr 4, 2025
Merged
Conversation
Comment on lines
+290
to
+294
| reportError( | ||
| errorMessage, | ||
| errorType: PropertyEditorSidebar.getEditableArgumentsIdentifier, | ||
| stack: st, | ||
| ); |
Member
There was a problem hiding this comment.
nit: we could reduce duplication by putting this in a finally clause. If we had a variable String? errorMessage defined before the try, the on RpcException and catch blocks could just set the errorMessage variable that is used in the finally block that calls reportError
Comment on lines
+338
to
+342
| reportError( | ||
| errorMessage, | ||
| errorType: PropertyEditorSidebar.editArgumentIdentifier, | ||
| stack: st, | ||
| ); |
kenzieschmoll
approved these changes
Apr 4, 2025
Member
kenzieschmoll
left a comment
kenzieschmoll
left a comment
There was a problem hiding this comment.
a couple comments but lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9086
This PR:
contentModifiedErrorreturned fromgetEditableArguments. This is expected if a user edits their code before the request completes. Because another request is sent afterwards, this is expected and does affect functionality.