Don't report error to user if script parsing fails#9104
Merged
elliette merged 2 commits intoflutter:masterfrom Apr 4, 2025
Merged
Don't report error to user if script parsing fails#9104elliette merged 2 commits intoflutter:masterfrom
elliette merged 2 commits intoflutter:masterfrom
Conversation
elliette
changed the title
kenzieschmoll
approved these changes
Apr 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've gotten many reports of script parsing failure (see #7192), but none with details about how to reproduce or how it affects Devtools.
Only issue with any details indicates it's user error (trying to reload a disconnected Devtools instance): #7192
I've done some investigation, and if script parsing fails the only screen affected is the debugger screen (however, the error is shown immediately on connecting to Devtools regardless of which screen your are on).
Since 1) the debugger screen is in maintenance mode and 2) if something is actually not working as expected it would be preferred to get a real issue filed with repro steps, I think it's safe to remove reporting this error to users.