Skip to content

Don't report error to user if script parsing fails #9104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elliette merged 2 commits into from
Apr 4, 2025
Merged

Don't report error to user if script parsing fails #9104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b4bc7c
Stop reporting error to user
elliette Apr 4, 2025
4dea2ce
Remove test case
elliette Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/devtools_app/lib/src/screens/debugger/codeview_controller.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,6 @@ class CodeViewController extends DisposableController
reportError(
'Failed to parse ${scriptRef.uri}.',
stack: StackTrace.current,
notifyUser: true,
);
return false;
}
Expand Down
19 changes: 0 additions & 19 deletions packages/devtools_app/test/screens/debugger/debugger_scripts_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,25 +217,6 @@ void main() {
]);
},
);

testWidgetsWithWindowSize('an error message is shown', smallWindowSize, (
WidgetTester tester,
) async {
await pumpDebuggerScreen(tester, mockDebuggerController);
// Dismiss any previous notifications:
notificationService.dismiss(
'Failed to parse package:gallery/src/unknown.dart.',
);
await tester.pumpAndSettle();

await showScript(mockEmptyScriptRef);
await tester.pumpAndSettle();

expect(
notificationService.activeMessages.first.text,
equals('Failed to parse package:gallery/src/unknown.dart.'),
);
});
});
}

Expand Down
Loading