[Property Editor] Include error code in exceptions sent to GA#9209
Merged
elliette merged 2 commits intoflutter:masterfrom May 27, 2025
Merged
[Property Editor] Include error code in exceptions sent to GA#9209elliette merged 2 commits intoflutter:masterfrom
elliette merged 2 commits intoflutter:masterfrom
Conversation
elliette
requested review from
DanTup,
bkonyi and
kenzieschmoll
and removed request for
a team and
bkonyi
DanTup
reviewed
May 27, 2025
kenzieschmoll
approved these changes
May 27, 2025
Member
kenzieschmoll
left a comment
kenzieschmoll
left a comment
There was a problem hiding this comment.
+1 to Danny's question but LGTM
Member
Author
|
Note: it turns out we have more info about why an edit failed than I initially thought. I still think this is a useful change to make querying the data easier, but I don't think it justifies a CP anymore. |
DanTup
approved these changes
May 27, 2025
hrajwade96
pushed a commit
to hrajwade96/devtools
that referenced
this pull request
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our current property edit exceptions in GA are not very helpful for figuring out why an edit did not succeed:
This adds the error code so that we can figure out why these edits didn't succeed. I am planning on doing a DevTools CP with these changes.