Skip to content

[Property Editor] Include error code in exceptions sent to GA #9209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elliette merged 2 commits into from
May 27, 2025
Merged

[Property Editor] Include error code in exceptions sent to GA #9209

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
486f3f5
Include error code in property editor errors
elliette May 27, 2025
c690fd4
Include both error messages if they exist
elliette May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions ...devtools_app/lib/src/standalone_ui/ide_shared/property_editor/property_editor_inputs.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,8 +386,7 @@ mixin _PropertyInputMixin<T extends StatefulWidget, U> on State<T> {
final succeeded = errorResponse == null || errorResponse.success;
if (!succeeded) {
setState(() {
_serverError =
'${errorResponse.errorType?.message ?? 'Encountered unknown error.'} (Property: ${property.name})';
_serverError = _errorMessage(errorResponse, property: property);
});
ga.reportError('property-editor $_serverError');
}
Expand All @@ -400,4 +399,20 @@ mixin _PropertyInputMixin<T extends StatefulWidget, U> on State<T> {
),
);
}

String _errorMessage(
EditArgumentResponse errorResponse, {
required EditableProperty property,
}) {
final errorType = errorResponse.errorType;
final messageFromType = errorType?.message;
final messageFromResponse = errorResponse.errorMessage;
final errorMessage =
(messageFromType != null && messageFromResponse != null)
? '$messageFromType / $messageFromResponse'
: messageFromType ?? messageFromResponse ?? 'Unknown error.';
final propertyInfo = '(Property: ${property.name})';
final errorCode = errorType?.code != null ? '${errorType!.code}: ' : '';
return '$errorCode$errorMessage $propertyInfo';
}
}