Skip to content

[Property Editor] Add UI for triggering "Wrap with" refactors#9213

Merged
elliette merged 19 commits intoflutter:masterfrom
elliette:black-and-white-buttosn
May 30, 2025
Merged

[Property Editor] Add UI for triggering "Wrap with" refactors#9213
elliette merged 19 commits intoflutter:masterfrom
elliette:black-and-white-buttosn

Conversation

@elliette
Copy link
Copy Markdown
Member

@elliette elliette commented May 28, 2025

Work towards #8652

Adds the UI to trigger a refactor from the Property Editor.

Screenshot 2025-05-30 at 11 18 44 AM

@elliette elliette requested review from a team and kenzieschmoll as code owners May 28, 2025 22:38
@elliette elliette changed the title Black and white buttosn [Property Editor] Add UI for triggering "Wrap with" refactors May 28, 2025
@elliette
Copy link
Copy Markdown
Member Author

Note: Still working on tests, will add them to PR when done.

@kenzieschmoll
Copy link
Copy Markdown
Member

UI comment: instead of having show more show a list of chips, can we just have a dropdown / overflow menu with these options, that way we don't have to take up more vertical space in the property editor? A dropdown / overflow menu to look at for inspiration is the DevTools tab bar. When the DevTools window in the browser is narrow, we put additional tabs into an overflow menu.

Comment thread packages/devtools_app_shared/lib/src/ui/theme/theme.dart Outdated
Copy link
Copy Markdown
Member

@kenzieschmoll kenzieschmoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits but generally LGTM once tests are cleaned up

Comment thread packages/devtools_app/lib/src/shared/feature_flags.dart Outdated
@elliette elliette merged commit d4d4e4c into flutter:master May 30, 2025
41 checks passed
hrajwade96 pushed a commit to hrajwade96/devtools that referenced this pull request Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants