Skip to content

Show Timer events in the Logging View#9238

Merged
derekxu16 merged 4 commits intoflutter:masterfrom
derekxu16:show-timer-events-in-logging-view
Jun 13, 2025
Merged

Show Timer events in the Logging View#9238
derekxu16 merged 4 commits intoflutter:masterfrom
derekxu16:show-timer-events-in-logging-view

Conversation

@derekxu16
Copy link
Copy Markdown
Contributor

@derekxu16 derekxu16 commented Jun 3, 2025

I have added a new Timer stream to the VM Service. This PR makes events sent on that stream appear in the Logging View. Currently, the only events that can appear on the Timer stream are warnings issued whenever a timer fires later than expected.

e.g.

Screenshot 2025-06-13 at 9 17 51 AM

@derekxu16 derekxu16 force-pushed the show-timer-events-in-logging-view branch 2 times, most recently from 1be2b08 to 029978e Compare June 3, 2025 15:43
Comment thread flutter-candidate.txt Outdated
@derekxu16 derekxu16 marked this pull request as ready for review June 3, 2025 16:32
@derekxu16 derekxu16 requested a review from a team as a code owner June 3, 2025 16:32
@derekxu16 derekxu16 requested review from kenzieschmoll and removed request for a team June 3, 2025 16:32
@kenzieschmoll
Copy link
Copy Markdown
Member

Nit: consider adding some logic here to use a timer / stopwatch icon for the "kind" chip: https://github.com/flutter/devtools/blob/master/packages/devtools_app/lib/src/screens/logging/metadata.dart/#L199

Comment thread packages/devtools_app/lib/src/screens/logging/logging_controller.dart Outdated
@derekxu16 derekxu16 force-pushed the show-timer-events-in-logging-view branch from 6bc6d0e to 3c51868 Compare June 4, 2025 15:58
Comment thread packages/devtools_app/lib/src/screens/logging/metadata.dart Outdated
Comment thread packages/devtools_app/lib/src/screens/logging/metadata.dart
@derekxu16 derekxu16 force-pushed the show-timer-events-in-logging-view branch from 3a0d3f8 to 21f4503 Compare June 9, 2025 14:30
@derekxu16 derekxu16 force-pushed the show-timer-events-in-logging-view branch from 21f4503 to f347410 Compare June 12, 2025 22:35
@derekxu16 derekxu16 merged commit 5436ea4 into flutter:master Jun 13, 2025
41 checks passed
@derekxu16 derekxu16 deleted the show-timer-events-in-logging-view branch June 13, 2025 18:13
hrajwade96 pushed a commit to hrajwade96/devtools that referenced this pull request Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants