Skip to content

Use --no-minify-wasm when creating devtools for releases.#9284

Merged
biggs0125 merged 3 commits intoflutter:masterfrom
biggs0125:add-wasm-no-minify
Jul 2, 2025
Merged

Use --no-minify-wasm when creating devtools for releases.#9284
biggs0125 merged 3 commits intoflutter:masterfrom
biggs0125:add-wasm-no-minify

Conversation

@biggs0125
Copy link
Copy Markdown
Contributor

In order to better debug WASM-specific errors, disable minification of wasm builds of devtools.

Also adds support for the flag to the local development CLI so that it can be used when debugging wasm locally.

The --no-minify-wasm flag was added here:
flutter/flutter@85486ff

@biggs0125
Copy link
Copy Markdown
Contributor Author

@kenzieschmoll Does this have to wait to land until after the pinned Flutter candidate has been updated to include the change I linked to above?

@kenzieschmoll
Copy link
Copy Markdown
Member

@kenzieschmoll Does this have to wait to land until after the pinned Flutter candidate has been updated to include the change I linked to above?

Yes, otherwise the flag will likely be a no-op or the build will fail if passing the flag prior to your flutter change would cause a crash.

@biggs0125
Copy link
Copy Markdown
Contributor Author

@kenzieschmoll Does this have to wait to land until after the pinned Flutter candidate has been updated to include the change I linked to above?

Yes, otherwise the flag will likely be a no-op or the build will fail if passing the flag prior to your flutter change would cause a crash.

The flag would be unrecognized without that other change so I think it would likely crash. I'll hold off landing this until that version bump happens.

@kenzieschmoll
Copy link
Copy Markdown
Member

You can go ahead and update the Flutter hash in this PR. Update the hash in flutter-candidate.txt to a0711824a5bac6a4bb9703b5e11601004db3d14b (the latest in g3 which looks like it does include your change)

@biggs0125 biggs0125 requested a review from a team as a code owner July 2, 2025 18:17
@biggs0125 biggs0125 requested review from bkonyi and removed request for a team July 2, 2025 18:17
@biggs0125 biggs0125 merged commit b36dac6 into flutter:master Jul 2, 2025
41 checks passed
hrajwade96 pushed a commit to hrajwade96/devtools that referenced this pull request Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants