Skip to content

Create preparing-pr skill #9752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kenzieschmoll merged 2 commits into from
Apr 9, 2026
Merged

Create preparing-pr skill #9752

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ed4c39
Create `preparing-pr` skill
kenzieschmoll Apr 2, 2026
c9a618e
use relative path
kenzieschmoll Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .agents/skills/preparing-pr/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
---
name: preparing-pr
description: Prepare a pull request by running presubmit with fixes. Use when preparing to commit or send a PR.
---

# Preparing a Pull Request

Follow these steps to prepare a pull request for DevTools:

1. **Verify `dt` configuration**:
- Ensure `dt` is available on the path by running `dt --help` or verifying its alias.
- If not available, refer to the [CONTRIBUTING guide](file:///Users/kenzieschmoll/develop/devtools/CONTRIBUTING.md#L64-L80) for instructions on how to set up the `dt` executable on your path.
Comment thread
kenzieschmoll marked this conversation as resolved.
Outdated
2. **Update Flutter SDK**:
- Run `dt update-flutter-sdk` to ensure the SDK is up to date.
3. **Run Presubmit with Fixes**:
- Run `dt presubmit --fix` to address automated fixes.
- If any issues remain or if the command fails, fix the issues manually and run `dt presubmit --fix` again to verify the fix.
4. **Run Tests for Affected Code**:
- Use `git status` or `git diff upstream/master` to find changed files.
- Run tests that are associated with the changed code. For example, if you edited `packages/devtools_app/lib/src/screens/logging/logging_screen.dart`, run the logging tests under `packages/devtools_app/test/screens/logging/`.

## Verification

If any step fails, stop and address the issue, and then verify the issue is fixed before proceeding.

> [!IMPORTANT]
> Do NOT commit or push changes without getting explicit user approval first.
Loading