Rename Inspector V2 --> Inspector#9796
Merged
elliette merged 13 commits intoflutter:masterfrom Apr 22, 2026
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request promotes the "Inspector V2" to the default inspector by renaming directories, updating imports, and removing the inspectorV2 feature flag across the codebase. It also cleans up related analytics metrics, documentation imports, and integration test goldens. Feedback focuses on the DiagnosticsNodeDescription widget, where the new logic for preserving font sizes during style merges is flagged as redundant and potentially incorrect. It is recommended to simplify these merges by using copyWith(fontSize: null) on the incoming styles to prevent them from overwriting the existing font size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7860
Work towards #9563
Follow up to #9782
This PR:
inspector_v2->inspectorNote: The only exception is our analytics. I kept the inspector V2 analytics dimension, which is
truefor any inspector usage