Remove unused code in integration_test and shared - #9916
Open
kenzieschmoll wants to merge 22 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request performs a large-scale cleanup of unused code, deprecated preferences, and redundant helper methods across the DevTools codebase. It also introduces a prettyPrint() extension on Object? to replace various inline usages of JsonEncoder.withIndent. A concern was raised regarding this extension, as defining it on Object? pollutes the autocomplete namespace for all types and reduces type safety. It is recommended to use a top-level helper function instead.
srawlins
approved these changes
Jul 27, 2026
| Stream<PostMessageEvent> get onPostMessage => | ||
| throw UnsupportedError('unsupported platform'); | ||
|
|
||
| // ignore: unused-code, currently unused but an important helper to keep. |
Contributor
There was a problem hiding this comment.
Why this would be important to keep? Can we leave a reason for the next person to look at this code?
If it is tested in tests, would it still be reported as unused?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work towards #9906