Skip to content

Commit 2688822

Browse files
committed
Update build_apk_test and build_aar_test for new build name/number dart-defines
FLUTTER_BUILD_NAME and FLUTTER_BUILD_NUMBER are now injected into the dart-defines passed to Gradle, which broke the hardcoded expectations in these command tests.
1 parent dc80b36 commit 2688822

2 files changed

Lines changed: 14 additions & 0 deletions

File tree

packages/flutter_tools/test/commands.shard/permeable/build_aar_test.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -376,6 +376,8 @@ void main() {
376376
'-q',
377377
'-Ptarget=${globals.fs.path.join('lib', 'main.dart')}',
378378
'-Pdart-defines=${encodeDartDefinesMap(<String, String>{
379+
'FLUTTER_BUILD_NAME': '1.0.0',
380+
'FLUTTER_BUILD_NUMBER': '1',
379381
'FLUTTER_VERSION': '0.0.0', //
380382
'FLUTTER_CHANNEL': 'master',
381383
'FLUTTER_GIT_URL': 'https://github.com/flutter/flutter.git',

packages/flutter_tools/test/commands.shard/permeable/build_apk_test.dart

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -522,6 +522,8 @@ void main() {
522522
'-Ptarget=${globals.fs.path.join(tempDir.path, 'flutter_project', 'lib', 'main.dart')}',
523523
'-Pbase-application-name=android.app.Application',
524524
'-Pdart-defines=${encodeDartDefinesMap(<String, String>{
525+
'FLUTTER_BUILD_NAME': '1.0.0',
526+
'FLUTTER_BUILD_NUMBER': '1',
525527
'FLUTTER_VERSION': '0.0.0', //
526528
'FLUTTER_CHANNEL': 'master',
527529
'FLUTTER_GIT_URL': 'https://github.com/flutter/flutter.git',
@@ -569,6 +571,8 @@ void main() {
569571
'-Ptarget=${globals.fs.path.join(tempDir.path, 'flutter_project', 'lib', 'main.dart')}',
570572
'-Pbase-application-name=android.app.Application',
571573
'-Pdart-defines=${encodeDartDefinesMap(<String, String>{
574+
'FLUTTER_BUILD_NAME': '1.0.0',
575+
'FLUTTER_BUILD_NUMBER': '1',
572576
'FLUTTER_VERSION': '0.0.0', //
573577
'FLUTTER_CHANNEL': 'master',
574578
'FLUTTER_GIT_URL': 'https://github.com/flutter/flutter.git',
@@ -620,6 +624,8 @@ void main() {
620624
'-Ptarget=${globals.fs.path.join(tempDir.path, 'flutter_project', 'lib', 'main.dart')}',
621625
'-Pbase-application-name=android.app.Application',
622626
'-Pdart-defines=${encodeDartDefinesMap(<String, String>{
627+
'FLUTTER_BUILD_NAME': '1.0.0',
628+
'FLUTTER_BUILD_NUMBER': '1',
623629
'FLUTTER_VERSION': '0.0.0', //
624630
'FLUTTER_CHANNEL': 'master',
625631
'FLUTTER_GIT_URL': 'https://github.com/flutter/flutter.git',
@@ -671,6 +677,8 @@ void main() {
671677
'-Ptarget=${globals.fs.path.join(tempDir.path, 'flutter_project', 'lib', 'main.dart')}',
672678
'-Pbase-application-name=android.app.Application',
673679
'-Pdart-defines=${encodeDartDefinesMap(<String, String>{
680+
'FLUTTER_BUILD_NAME': '1.0.0',
681+
'FLUTTER_BUILD_NUMBER': '1',
674682
'FLUTTER_VERSION': '0.0.0', //
675683
'FLUTTER_CHANNEL': 'master',
676684
'FLUTTER_GIT_URL': 'https://github.com/flutter/flutter.git',
@@ -724,6 +732,8 @@ void main() {
724732
'-Ptarget=${globals.fs.path.join(tempDir.path, 'flutter_project', 'lib', 'main.dart')}',
725733
'-Pbase-application-name=android.app.Application',
726734
'-Pdart-defines=${encodeDartDefinesMap(<String, String>{
735+
'FLUTTER_BUILD_NAME': '1.0.0',
736+
'FLUTTER_BUILD_NUMBER': '1',
727737
'FLUTTER_VERSION': '0.0.0', //
728738
'FLUTTER_CHANNEL': 'master',
729739
'FLUTTER_GIT_URL': 'https://github.com/flutter/flutter.git',
@@ -782,6 +792,8 @@ void main() {
782792
'-Ptarget=${globals.fs.path.join(tempDir.path, 'flutter_project', 'lib', 'main.dart')}',
783793
'-Pbase-application-name=android.app.Application',
784794
'-Pdart-defines=${encodeDartDefinesMap(<String, String>{
795+
'FLUTTER_BUILD_NAME': '1.0.0',
796+
'FLUTTER_BUILD_NUMBER': '1',
785797
'FLUTTER_VERSION': '0.0.0', //
786798
'FLUTTER_CHANNEL': 'master',
787799
'FLUTTER_GIT_URL': 'https://github.com/flutter/flutter.git',

0 commit comments

Comments
 (0)