fix: surface catalog ID in PromptBuilder#919
Open
gspencergoog wants to merge 8 commits into
Open
Conversation
gspencergoog
force-pushed
the
add_catalog_id
branch
from
dbaf1bd to
133685f
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Collaborator
Author
|
/gemini review |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…lable active catalog ID
- Escape backslashes (`\`) and carriage returns (`\r`) inside `catalogId` in `prompt_builder.dart` to prevent quote escaping and line-break injections in system prompts.
- Update `SurfaceOperations` documentation and prompt instructions to refer conditionally to the active catalog ID ("if provided"), resolving a logic inconsistency when `catalogId` is null.
- Update test suite and regenerate prompt builder golden files to assert new sanitization patterns and conditional wording.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR Fixes #900 by surfacing the catalog ID in the system prompt generated by
PromptBuilderwhen it is provided in theCatalog.Changes
The active catalog ID is: "${catalog.catalogId}".ifcatalog.catalogIdis not null.Impact & Risks
Testing
prompt_builder_test.dartand verified that all 10 tests pass.