[webview_flutter_wkwebview] Follow RFC 6265 guideline for getCookies domain matching

Author: khaled-0

packages/webview_flutter/webview_flutter_wkwebview/lib/src/webkit_webview_cookie_manager.dart

@@ -92,7 +92,14 @@ class WebKitWebViewCookieManager extends PlatformWebViewCookieManager {
       }
 
       final domain = props[HttpCookiePropertyKey.domain].toString();
-      if (!domain.contains(url.host)) {
+
+      // Follow RFC 6265 guideline for domain matching
+      var cookieDomain = domain;
+      if (domain.startsWith('.')) {
+        cookieDomain = cookieDomain.substring(1);
+      }
+
+      if (url.host != cookieDomain && !url.host.endsWith('.$cookieDomain')) {
         return null;
       }
 

packages/webview_flutter/webview_flutter_wkwebview/test/webkit_webview_cookie_manager_test.dart

@@ -115,6 +115,7 @@ void main() {
       // Mock cookies returned by the cookie store
       final mockCookie1 = MockHTTPCookie();
       final mockCookie2 = MockHTTPCookie();
+      final mockCookie3 = MockHTTPCookie();
 
       when(mockCookie1.getProperties()).thenAnswer(
         (_) async => <HttpCookiePropertyKey, Object>{
@@ -134,9 +135,18 @@ void main() {
         },
       );
 
+      when(mockCookie3.getProperties()).thenAnswer(
+        (_) async => <HttpCookiePropertyKey, Object>{
+          HttpCookiePropertyKey.name: 'cookie3',
+          HttpCookiePropertyKey.value: 'value3',
+          HttpCookiePropertyKey.domain: '.flutter.dev',
+          HttpCookiePropertyKey.path: '/path',
+        },
+      );
+
       when(
         mockCookieStore.getAllCookies(),
-      ).thenAnswer((_) async => [mockCookie1, mockCookie2]);
+      ).thenAnswer((_) async => [mockCookie1, mockCookie2, mockCookie3]);
 
       PigeonOverrides.wKWebsiteDataStore_defaultDataStore =
           mockWKWebsiteDataStore;
@@ -149,7 +159,7 @@ void main() {
         Uri.parse('https://flutter.dev'),
       );
 
-      expect(cookies.length, 2);
+      expect(cookies.length, 3);
 
       expect(cookies[0].name, 'cookie1');
       expect(cookies[0].value, 'value1');
@@ -160,6 +170,17 @@ void main() {
       expect(cookies[1].value, 'value2');
       expect(cookies[1].domain, 'flutter.dev');
       expect(cookies[1].path, '/path');
+
+      final List<WebViewCookie> cookiesWww = await manager.getCookies(
+        Uri.parse('https://www.flutter.dev'),
+      );
+
+      expect(cookiesWww.length, 3);
+
+      expect(cookiesWww[2].name, 'cookie3');
+      expect(cookiesWww[2].value, 'value3');
+      expect(cookiesWww[2].domain, '.flutter.dev');
+      expect(cookiesWww[2].path, '/path');
     });
   });
 }