Skip to content

Commit 4bea773

Browse files
authored
[material_ui] Remove widgets import in animated_icon_test.dart and autocomplete_test.dart (#12000)
Part of flutter/flutter#182636 and flutter/flutter#188395 This PR: * Removed the cross-import of `widgets/semantics_tester.dart`. * Removed @Skip tag, all tests in this file has passed. `semantics_tester.dart` has existed in material_ui, so we can directly import `semantics_tester.dart`; * Moved the file to `test/` folder. ## Pre-Review Checklist
1 parent f588865 commit 4bea773

2 files changed

Lines changed: 5 additions & 10 deletions

File tree

packages/material_ui/temporarily_disabled_tests/animated_icons_test.dart renamed to packages/material_ui/test/animated_icons_test.dart

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,15 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5-
@Skip(
6-
'This file is skipped due to a cross-import that needs to be fixed. Tracked in https://github.com/flutter/flutter/issues/177028.',
7-
)
85
@Tags(<String>['reduced-test-set'])
96
library;
107

118
import 'dart:math' as math show pi;
129

13-
import 'package:material_ui/material_ui.dart';
1410
import 'package:flutter_test/flutter_test.dart';
15-
import '../widgets/semantics_tester.dart';
11+
import 'package:material_ui/material_ui.dart';
12+
13+
import 'semantics_tester.dart';
1614

1715
class MockCanvas extends Fake implements Canvas {
1816
late Path capturedPath;

packages/material_ui/temporarily_disabled_tests/autocomplete_test.dart renamed to packages/material_ui/test/autocomplete_test.dart

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,11 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5-
@Skip(
6-
'This file is skipped due to a cross-import that needs to be fixed. Tracked in https://github.com/flutter/flutter/issues/177028.',
7-
)
8-
import 'package:material_ui/material_ui.dart';
95
import 'package:flutter/services.dart';
106
import 'package:flutter_test/flutter_test.dart';
7+
import 'package:material_ui/material_ui.dart';
118

12-
import '../widgets/semantics_tester.dart';
9+
import 'semantics_tester.dart';
1310

1411
class User {
1512
const User({required this.email, required this.name});

0 commit comments

Comments
 (0)