Skip to content

Commit 523fff0

Browse files
authored
[material_ui] Remove widgets import in data_table_test.dart, switch_test.dart and tooltip_theme_test.dart (#12031)
Part of flutter/flutter#182636 and flutter/flutter#188395 This PR: * Removed the cross-import of `widgets/semantics_tester.dart`. * Removed @Skip tag, all tests in this file has passed. `semantics_tester.dart` has existed in material_ui, so we can directly import `semantics_tester.dart`; * Moved the file to `test/` folder. ## Pre-Review Checklist
1 parent 9d4c585 commit 523fff0

3 files changed

Lines changed: 7 additions & 15 deletions

File tree

packages/material_ui/temporarily_disabled_tests/data_table_test.dart renamed to packages/material_ui/test/data_table_test.dart

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,23 +2,20 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5-
@Skip(
6-
'This file is skipped due to a cross-import that needs to be fixed. Tracked in https://github.com/flutter/flutter/issues/177028.',
7-
)
85
@TestOn('!chrome')
96
library;
107

118
import 'dart:math' as math;
129

1310
import 'package:flutter/foundation.dart' show kIsWeb;
1411
import 'package:flutter/gestures.dart';
15-
import 'package:material_ui/material_ui.dart';
1612
import 'package:flutter/rendering.dart';
1713
import 'package:flutter_test/flutter_test.dart';
14+
import 'package:material_ui/material_ui.dart';
1815
import 'package:vector_math/vector_math_64.dart' show Matrix3;
1916

20-
import '../widgets/semantics_tester.dart';
2117
import 'data_table_test_utils.dart';
18+
import 'semantics_tester.dart';
2219

2320
void main() {
2421
testWidgets('DataTable control test', (WidgetTester tester) async {

packages/material_ui/temporarily_disabled_tests/switch_test.dart renamed to packages/material_ui/test/switch_test.dart

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5-
@Skip(
6-
'This file is skipped due to a cross-import that needs to be fixed. Tracked in https://github.com/flutter/flutter/issues/177028.',
7-
)
85
// This file is run as part of a reduced test set in CI on Mac and Windows
96
// machines.
107
@Tags(<String>['reduced-test-set'])
@@ -16,12 +13,12 @@ import 'dart:ui' as ui;
1613
import 'package:cupertino_ui/cupertino_ui.dart';
1714
import 'package:flutter/foundation.dart';
1815
import 'package:flutter/gestures.dart';
19-
import 'package:material_ui/material_ui.dart';
2016
import 'package:flutter/rendering.dart';
2117
import 'package:flutter/services.dart';
2218
import 'package:flutter_test/flutter_test.dart';
19+
import 'package:material_ui/material_ui.dart';
2320

24-
import '../widgets/semantics_tester.dart';
21+
import 'semantics_tester.dart';
2522

2623
void main() {
2724
final theme = ThemeData();

packages/material_ui/temporarily_disabled_tests/tooltip_theme_test.dart renamed to packages/material_ui/test/tooltip_theme_test.dart

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,13 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5-
@Skip(
6-
'This file is skipped due to a cross-import that needs to be fixed. Tracked in https://github.com/flutter/flutter/issues/177028.',
7-
)
85
import 'package:flutter/gestures.dart';
9-
import 'package:material_ui/material_ui.dart';
106
import 'package:flutter/rendering.dart';
117
import 'package:flutter/services.dart';
128
import 'package:flutter_test/flutter_test.dart';
13-
import '../widgets/semantics_tester.dart';
9+
import 'package:material_ui/material_ui.dart';
10+
11+
import 'semantics_tester.dart';
1412

1513
const String tooltipText = 'TIP';
1614
const double _customPaddingValue = 10.0;

0 commit comments

Comments
 (0)