Skip to content

Commit 900a4f4

Browse files
snaejiclaude
andcommitted
[google_maps_flutter_android] Loop over enum values in toMapColorScheme tests
Replaces three per-value tests with one loop over PlatformMapColorScheme.values() so a new enum value forces a compile-time failure in the test when it grows. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 04a6aa2 commit 900a4f4

1 file changed

Lines changed: 10 additions & 18 deletions

File tree

  • packages/google_maps_flutter/google_maps_flutter_android/android/src/test/java/io/flutter/plugins/googlemaps

packages/google_maps_flutter/google_maps_flutter_android/android/src/test/java/io/flutter/plugins/googlemaps/ConvertTest.java

Lines changed: 10 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -522,24 +522,16 @@ public void interpretMapConfiguration_handlesStyle() {
522522
}
523523

524524
@Test
525-
public void toMapColorScheme_light() {
526-
Assert.assertEquals(
527-
com.google.android.gms.maps.model.MapColorScheme.LIGHT,
528-
Convert.toMapColorScheme(PlatformMapColorScheme.LIGHT));
529-
}
530-
531-
@Test
532-
public void toMapColorScheme_dark() {
533-
Assert.assertEquals(
534-
com.google.android.gms.maps.model.MapColorScheme.DARK,
535-
Convert.toMapColorScheme(PlatformMapColorScheme.DARK));
536-
}
537-
538-
@Test
539-
public void toMapColorScheme_followSystem() {
540-
Assert.assertEquals(
541-
com.google.android.gms.maps.model.MapColorScheme.FOLLOW_SYSTEM,
542-
Convert.toMapColorScheme(PlatformMapColorScheme.FOLLOW_SYSTEM));
525+
public void toMapColorScheme_mapsAllPlatformValues() {
526+
for (PlatformMapColorScheme value : PlatformMapColorScheme.values()) {
527+
final int expected =
528+
switch (value) {
529+
case LIGHT -> com.google.android.gms.maps.model.MapColorScheme.LIGHT;
530+
case DARK -> com.google.android.gms.maps.model.MapColorScheme.DARK;
531+
case FOLLOW_SYSTEM -> com.google.android.gms.maps.model.MapColorScheme.FOLLOW_SYSTEM;
532+
};
533+
Assert.assertEquals(expected, Convert.toMapColorScheme(value));
534+
}
543535
}
544536

545537
@Test

0 commit comments

Comments
 (0)