Skip to content

Commit c2d2c1c

Browse files
authored
[material_ui] Enable popup_menu_test (#12018)
Port over `popup_menu_test` from flutter/flutter#184279 Work towards flutter/flutter#182636 and flutter/flutter#188395 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
1 parent 0615e3c commit c2d2c1c

1 file changed

Lines changed: 11 additions & 11 deletions

File tree

packages/material_ui/temporarily_disabled_tests/popup_menu_test.dart renamed to packages/material_ui/test/popup_menu_test.dart

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,18 +2,16 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5-
@Skip(
6-
'This file is skipped due to a cross-import that needs to be fixed. Tracked in https://github.com/flutter/flutter/issues/177028.',
7-
)
5+
import 'dart:async';
86
import 'dart:ui';
97

108
import 'package:flutter/foundation.dart';
11-
import 'package:material_ui/material_ui.dart';
129
import 'package:flutter/rendering.dart';
1310
import 'package:flutter_test/flutter_test.dart';
11+
import 'package:material_ui/material_ui.dart';
1412

15-
import '../widgets/feedback_tester.dart';
16-
import '../widgets/semantics_tester.dart';
13+
import 'feedback_tester.dart';
14+
import 'semantics_tester.dart';
1715

1816
void main() {
1917
testWidgets('Navigator.push works within a PopupMenuButton', (WidgetTester tester) async {
@@ -3725,11 +3723,13 @@ void main() {
37253723
final BuildContext context = tester.element(find.text('Go'));
37263724
const exampleSetting = RouteSettings(name: 'simple');
37273725

3728-
showMenu<void>(
3729-
context: context,
3730-
position: RelativeRect.fill,
3731-
items: const <PopupMenuItem<void>>[PopupMenuItem<void>(child: Text('foo'))],
3732-
routeSettings: exampleSetting,
3726+
unawaited(
3727+
showMenu<void>(
3728+
context: context,
3729+
position: RelativeRect.fill,
3730+
items: const <PopupMenuItem<void>>[PopupMenuItem<void>(child: Text('foo'))],
3731+
routeSettings: exampleSetting,
3732+
),
37333733
);
37343734

37353735
await tester.pumpAndSettle();

0 commit comments

Comments
 (0)