Skip to content

Commit c780d2d

Browse files
[google_maps_flutter] Remove .static from Package.swift (#11392)
The Swift Package Manager spec was requiring static builds, rather than following the Apple suggestion of letting the build process determine the build mode. This was a carryover from the CocoaPods spec, but based on commit history that was only to address some unspecified compatibility issue with Swift apps, long ago (before module builds were standard, for example). We are not aware of any reason for this setting that applies to Package.swift, so we should remove it absent new evidence that it is necessary. (Arguably we could remove it from the CP spec too, but since that's a legacy mode anyway, it's probably best to leave it as is to avoid any potential disruptions in edge cases we aren't aware of.) ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
1 parent 62949f4 commit c780d2d

File tree

6 files changed

+12
-8
lines changed

6 files changed

+12
-8
lines changed

packages/google_maps_flutter/google_maps_flutter_ios_sdk10/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 2.18.1
2+
3+
* Removes the requirement to use static builds with Swift Package Manager.
4+
15
## 2.18.0
26

37
* Adds support for advanced markers.

packages/google_maps_flutter/google_maps_flutter_ios_sdk10/ios/google_maps_flutter_ios_sdk10/Package.swift

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,7 @@ let package = Package(
1313
.iOS(.v16)
1414
],
1515
products: [
16-
.library(
17-
name: "google-maps-flutter-ios-sdk10", type: .static,
18-
targets: ["google_maps_flutter_ios_sdk10"])
16+
.library(name: "google-maps-flutter-ios-sdk10", targets: ["google_maps_flutter_ios_sdk10"])
1917
],
2018
dependencies: [
2119
.package(url: "https://github.com/googlemaps/ios-maps-sdk", "10.0.0"..<"11.0.0"),

packages/google_maps_flutter/google_maps_flutter_ios_sdk10/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: google_maps_flutter_ios_sdk10
22
description: iOS implementation of the google_maps_flutter plugin using Google Maps SDK 10.
33
repository: https://github.com/flutter/packages/tree/main/packages/google_maps_flutter/google_maps_flutter_ios_sdk10
44
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+maps%22
5-
version: 2.18.0
5+
version: 2.18.1
66

77
environment:
88
sdk: ^3.10.0

packages/google_maps_flutter/google_maps_flutter_ios_sdk9/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 2.18.1
2+
3+
* Removes the requirement to use static builds with Swift Package Manager.
4+
15
## 2.18.0
26

37
* Adds support for advanced markers.

packages/google_maps_flutter/google_maps_flutter_ios_sdk9/ios/google_maps_flutter_ios_sdk9/Package.swift

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,7 @@ let package = Package(
1313
.iOS(.v15)
1414
],
1515
products: [
16-
.library(
17-
name: "google-maps-flutter-ios-sdk9", type: .static, targets: ["google_maps_flutter_ios_sdk9"]
18-
)
16+
.library(name: "google-maps-flutter-ios-sdk9", targets: ["google_maps_flutter_ios_sdk9"])
1917
],
2018
dependencies: [
2119
.package(url: "https://github.com/googlemaps/ios-maps-sdk", "9.0.0"..<"10.0.0"),

packages/google_maps_flutter/google_maps_flutter_ios_sdk9/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: google_maps_flutter_ios_sdk9
22
description: iOS implementation of the google_maps_flutter plugin using Google Maps SDK 9.
33
repository: https://github.com/flutter/packages/tree/main/packages/google_maps_flutter/google_maps_flutter_ios_sdk9
44
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+maps%22
5-
version: 2.18.0
5+
version: 2.18.1
66

77
environment:
88
sdk: ^3.10.0

0 commit comments

Comments
 (0)