[tool] Unify most validation commands (#11641)

Replaces all of the following repo tooling commands with a new unified `validate` command:
- `dependabot-check`
- `gradle-check`
- `pubspec-check`
- `readme-check`
- `repo-package-info-check`
- `version-check`

It also makes some simplifications in using these:
- Temporarily disabling the code excerpt check is now done via package-level ci_config.yaml files. This means that we don't have to exempt a package from the entire command just for this, and also means that fixing a package and removing its exemption will no longer trigger whole-repo testing as it used to.
- Setting the min Flutter version allowed for the repo is now a repo-level config in a new root level `tool_config/` directory. This avoids the need to pass a flag every time for something that isn't actually intended to be variable.
- The allowed dependencies are now also in hard-coded locations in the `tool_config/` directory, instead of having to pass them in all the time, to make the commands easier to call. As with min SDK version, this isn't something callers actually need to be able to change on the fly to the flags add more complexity (in exchange for making it extremely clear at the CI call site what was happening, but I no longer think that tradeoff is the right one based on experience using the tool).

To avoid huge amounts of test file churn, and massively complicating test setup, there is a test-only mechanism to select individual validators to run in tests, rather than having to test the entire command at once.

Part of flutter/flutter#173413

Author: stuartmorgan-g

.ci/scripts/check_version.sh .ci/scripts/validate.sh.ci/scripts/check_version.sh renamed to .ci/scripts/validate.sh

@@ -10,7 +10,7 @@ set -e
 # missing version/CHANGELOG detection since PR-level overrides aren't available
 # in post-submit.
 if [[ $LUCI_PR == "" ]]; then
-  .ci/scripts/tool_runner.sh version-check --ignore-platform-interface-breaks
+  .ci/scripts/tool_runner.sh validate --ignore-platform-interface-breaks
 else
-  .ci/scripts/tool_runner.sh version-check --check-for-missing-changes --pr-labels="$PR_OVERRIDE_LABELS"
+  .ci/scripts/tool_runner.sh validate --check-for-missing-changes --pr-labels="$PR_OVERRIDE_LABELS"
 fi

.ci/targets/repo_checks.yaml

@@ -26,46 +26,12 @@ tasks:
     script: .ci/scripts/tool_runner.sh
     args: ["license-check"]
     always: true
-    # The major and minor version here should match the lowest version analyzed
-    # in legacy version analysis (.ci.yaml analyze_legacy).
-  - name: pubspec validation
-    script: .ci/scripts/tool_runner.sh
-    args:
-      - "pubspec-check"
-      - "--min-min-flutter-version=3.35.0"
-      - "--allow-dependencies=script/configs/allowed_unpinned_deps.yaml"
-      - "--allow-pinned-dependencies=script/configs/allowed_pinned_deps.yaml"
-    always: true
-  - name: README validation
-    script: .ci/scripts/tool_runner.sh
-    args: ["readme-check"]
-    always: true
-    # Re-run with --require-excerpts, skipping packages that still need
-    # to be converted. Once https://github.com/flutter/flutter/issues/102679
-    # has been fixed, this can be removed --require-excerpts added to the
-    # run above.
-  - name: README snippet configuration validation
-    script: .ci/scripts/tool_runner.sh
-    args: ["readme-check", "--require-excerpts", "--exclude=script/configs/temp_exclude_excerpt.yaml"]
-    always: true
   - name: README snippet validation
     script: .ci/scripts/tool_runner.sh
     args: ["update-excerpts", "--fail-on-change"]
     always: true
-  - name: Gradle validation
-    script: .ci/scripts/tool_runner.sh
-    args: ["gradle-check"]
-    always: true
-  - name: Repository-level package metadata validation
-    script: .ci/scripts/tool_runner.sh
-    args: ["check-repo-package-info"]
-    always: true
-  - name: Dependabot coverage validation
-    script: .ci/scripts/tool_runner.sh
-    args: ["dependabot-check"]
-    always: true
-  - name: CHANGELOG and version validation
-    script: .ci/scripts/check_version.sh
+  - name: Repository standards validation
+    script: .ci/scripts/validate.sh
     always: true
   - name: federated safety check
     script: .ci/scripts/check_federated_safety.sh

AGENTS.md

@@ -90,11 +90,9 @@ dart run $REPO_ROOT/script/tool/bin/flutter_plugin_tools.dart update-dependency
   The tool can also run native and integration tests, but these may require a more complete environment than is available.
 - **Validation**: Run these checks to ensure that changes follow team guidelines:
   ```bash
+  dart run $REPO_ROOT/script/tool/bin/flutter_plugin_tools.dart validate --packages <changed_packages>
   dart run $REPO_ROOT/script/tool/bin/flutter_plugin_tools.dart publish-check --packages <changed_packages>
-  dart run $REPO_ROOT/script/tool/bin/flutter_plugin_tools.dart readme-check --packages <changed_packages>
-  dart run $REPO_ROOT/script/tool/bin/flutter_plugin_tools.dart version-check --packages <changed_packages>
   dart run $REPO_ROOT/script/tool/bin/flutter_plugin_tools.dart license-check
-  dart run $REPO_ROOT/script/tool/bin/flutter_plugin_tools.dart repo-package-info-check
   ```
 
 ### Specialized Workflows

packages/espresso/ci_config.yaml

@@ -0,0 +1,2 @@
+# TODO(stuartmorgan): Remove this; see https://github.com/flutter/flutter/issues/102679
+exempt_from_excerpts: true

packages/in_app_purchase/in_app_purchase/ci_config.yaml

@@ -0,0 +1,2 @@
+# TODO(stuartmorgan): Remove this; see https://github.com/flutter/flutter/issues/102679
+exempt_from_excerpts: true

packages/pointer_interceptor/pointer_interceptor/ci_config.yaml

@@ -0,0 +1,2 @@
+# TODO(stuartmorgan): Remove this; see https://github.com/flutter/flutter/issues/102679
+exempt_from_excerpts: true

packages/quick_actions/quick_actions/ci_config.yaml

@@ -0,0 +1,2 @@
+# TODO(stuartmorgan): Remove this; see https://github.com/flutter/flutter/issues/102679
+exempt_from_excerpts: true

script/configs/temp_exclude_excerpt.yaml

@@ -49,7 +49,7 @@ dart run script/tool/bin/flutter_plugin_tools.dart format --packages package_nam
 
 The `flutter/packages` repository uses clang version `15.0.0` . Newer versions of clang may format code differently.
 
-### Run the Static Analysis
+### Run Static Analysis
 
 To analyze only Dart code:
 
@@ -68,6 +68,18 @@ dart run script/tool/bin/flutter_plugin_tools.dart analyze --ios --macos --packa
 
 Dart analysis can be excluded with `--no-dart`.
 
+### Run General Validation
+
+To check that changes follow team standards and best practices, run:
+
+```sh
+dart run script/tool/bin/flutter_plugin_tools.dart validate --check-for-missing-changes --packages package_name
+```
+
+If you are making changes that fall under a CHANGELOG and/or version change
+exemption you can omit the `--check-for-missing-changes` flag to skip those
+checks.
+
 ### Run Dart Unit Tests
 
 ```sh

script/tool/README.md

@@ -7,7 +7,7 @@ import 'package:yaml/yaml.dart';
 /// A class representing the parsed content of a `ci_config.yaml` file.
 class CIConfig {
   /// Creates a [CIConfig] from a parsed YAML map.
-  CIConfig._(this.isBatchRelease);
+  CIConfig._({required this.isBatchRelease, required this.requiresExcerpts});
 
   /// Parses a [CIConfig] from a YAML string.
   ///
@@ -26,18 +26,29 @@ class CIConfig {
       isBatchRelease = release['batch'] == true;
     }
 
-    return CIConfig._(isBatchRelease);
+    // Any package that hasn't been explicitly exempted is assumed to require
+    // excerpts.
+    final requiresExcerpts = loaded['exempt_from_excerpts'] != true;
+
+    return CIConfig._(
+      isBatchRelease: isBatchRelease,
+      requiresExcerpts: requiresExcerpts,
+    );
   }
 
   static const Map<String, Object?> _validCIConfigSyntax = <String, Object?>{
     'release': <String, Object?>{
       'batch': <bool>{true, false},
     },
+    'exempt_from_excerpts': <bool>{true, false},
   };
 
   /// Returns true if the package is configured for batch release.
   final bool isBatchRelease;
 
+  /// Returns true if the package is configured to require excerpts.
+  final bool requiresExcerpts;
+
   static void _checkCIConfigEntries(
     YamlMap config, {
     required Map<String, Object?> syntax,