Skip to content

Commit e727677

Browse files
authored
[material_ui] Enable floating_action_button_test (#12014)
Port over `floating_action_button_test` from flutter/flutter#184279 Work towards flutter/flutter#182636 and flutter/flutter#188395 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
1 parent 787157b commit e727677

1 file changed

Lines changed: 44 additions & 39 deletions

File tree

packages/material_ui/temporarily_disabled_tests/floating_action_button_test.dart renamed to packages/material_ui/test/floating_action_button_test.dart

Lines changed: 44 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -2,23 +2,22 @@
22
// Use of this source code is governed by a BSD-style license that can be
33
// found in the LICENSE file.
44

5-
@Skip(
6-
'This file is skipped due to a cross-import that needs to be fixed. Tracked in https://github.com/flutter/flutter/issues/177028.',
7-
)
85
// This file is run as part of a reduced test set in CI on Mac and Windows
96
// machines.
107
@Tags(<String>['reduced-test-set'])
118
@TestOn('!chrome')
129
library;
1310

11+
import 'dart:async';
1412
import 'dart:ui';
1513

1614
import 'package:flutter/foundation.dart' show kIsWeb;
17-
import 'package:material_ui/material_ui.dart';
1815
import 'package:flutter/rendering.dart';
1916
import 'package:flutter_test/flutter_test.dart';
20-
import '../widgets/feedback_tester.dart';
21-
import '../widgets/semantics_tester.dart';
17+
import 'package:material_ui/material_ui.dart';
18+
19+
import 'feedback_tester.dart';
20+
import 'semantics_tester.dart';
2221

2322
void main() {
2423
final material3Theme = ThemeData();
@@ -505,17 +504,19 @@ void main() {
505504
),
506505
),
507506
);
508-
Navigator.push(
509-
theContext,
510-
PageRouteBuilder<void>(
511-
pageBuilder:
512-
(
513-
BuildContext context,
514-
Animation<double> animation,
515-
Animation<double> secondaryAnimation,
516-
) {
517-
return const Placeholder();
518-
},
507+
unawaited(
508+
Navigator.push(
509+
theContext,
510+
PageRouteBuilder<void>(
511+
pageBuilder:
512+
(
513+
BuildContext context,
514+
Animation<double> animation,
515+
Animation<double> secondaryAnimation,
516+
) {
517+
return const Placeholder();
518+
},
519+
),
519520
),
520521
);
521522
await tester
@@ -537,17 +538,19 @@ void main() {
537538
),
538539
),
539540
);
540-
Navigator.push(
541-
theContext,
542-
PageRouteBuilder<void>(
543-
pageBuilder:
544-
(
545-
BuildContext context,
546-
Animation<double> animation,
547-
Animation<double> secondaryAnimation,
548-
) {
549-
return const Placeholder();
550-
},
541+
unawaited(
542+
Navigator.push(
543+
theContext,
544+
PageRouteBuilder<void>(
545+
pageBuilder:
546+
(
547+
BuildContext context,
548+
Animation<double> animation,
549+
Animation<double> secondaryAnimation,
550+
) {
551+
return const Placeholder();
552+
},
553+
),
551554
),
552555
);
553556
await tester.pump();
@@ -569,17 +572,19 @@ void main() {
569572
),
570573
),
571574
);
572-
Navigator.push(
573-
theContext,
574-
PageRouteBuilder<void>(
575-
pageBuilder:
576-
(
577-
BuildContext context,
578-
Animation<double> animation,
579-
Animation<double> secondaryAnimation,
580-
) {
581-
return const Placeholder();
582-
},
575+
unawaited(
576+
Navigator.push(
577+
theContext,
578+
PageRouteBuilder<void>(
579+
pageBuilder:
580+
(
581+
BuildContext context,
582+
Animation<double> animation,
583+
Animation<double> secondaryAnimation,
584+
) {
585+
return const Placeholder();
586+
},
587+
),
583588
),
584589
);
585590
await tester.pump();

0 commit comments

Comments
 (0)