Skip to content

Commit ed7881e

Browse files
authored
[ci] use override: post-release-<package> label (#11429)
The ci only capture label that starts with `override:`. We can either (1) update the ci to capture more labels, or (2) update the post release label to start with `override:`. I figured adding `override:` prefix is more appropriate because the label is attempting to override verision check for batch release. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
1 parent 5299279 commit ed7881e

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

.github/workflows/sync_release_pr.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,4 +41,4 @@ jobs:
4141
--head "${{ github.ref_name }}" \
4242
--title "Sync ${{ github.ref_name }} to main" \
4343
--body "This automated PR syncs the changes from the release branch ${{ github.ref_name }} back to the main branch." \
44-
--label "post-${{ github.ref_name }}"
44+
--label "override: post-${{ github.ref_name }}"

script/tool/lib/src/version_check_command.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ class VersionCheckCommand extends PackageLoopingCommand {
248248
// PR with post release label is going to sync changelog.md and pubspec.yaml
249249
// change back to main branch. Proceed with regular version check.
250250
final bool hasPostReleaseLabel = _prLabels.contains(
251-
'post-release-${pubspec.name}',
251+
'override: post-release-${pubspec.name}',
252252
);
253253
bool versionChanged;
254254

script/tool/test/version_check_command_test.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2079,7 +2079,7 @@ release:
20792079
},
20802080
);
20812081
test(
2082-
'ignores changelog and pubspec yaml version modifications check with post-release label',
2082+
'ignores changelog and pubspec yaml version modifications check with override: post-release label',
20832083
() async {
20842084
final RepositoryPackage package = createFakePackage(
20852085
'package',
@@ -2112,7 +2112,7 @@ packages/package/pubspec.yaml
21122112
final List<String> output = await runCapturingPrint(runner, <String>[
21132113
'version-check',
21142114
'--base-sha=main',
2115-
'--pr-labels=post-release-package',
2115+
'--pr-labels=override: post-release-package',
21162116
]);
21172117

21182118
expect(

0 commit comments

Comments
 (0)