[google_maps_flutter] Android cluster pin info window onTap callback not firing#11390
Merged
auto-submit[bot] merged 3 commits intoflutter:mainfrom Apr 7, 2026
Merged
Conversation
elitree
force-pushed
the
fix/marker-info-window-clusters
branch
from
01f4b2f to
1ef8250
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for info window tap events on clustered markers in the Google Maps Android plugin. It introduces the OnClusterItemInfoWindowClickListener interface, implements it in GoogleMapController, and updates ClusterManagersController and MarkersController to handle the event and notify the Flutter API. Unit tests are included to verify the implementation. Feedback suggests refactoring MarkersController to reduce code duplication between the info window tap handlers.
Comment on lines
+310
to
+316
| /** | ||
| * Called when a cluster-managed marker's info window is tapped. Takes the Dart marker ID | ||
| * directly. | ||
| */ | ||
| void onClusterItemInfoWindowTap(String markerId) { | ||
| flutterApi.onInfoWindowTap(markerId, new NoOpVoidResult()); | ||
| } |
There was a problem hiding this comment.
To improve maintainability and reduce code duplication, you could refactor this new method and the existing onInfoWindowTap to share a common private method. The current implementation duplicates the call to flutterApi.onInfoWindowTap.
For example, you could introduce a private method that takes the Dart markerId and makes the API call. Then, both onInfoWindowTap (after resolving the googleMarkerId) and this new onClusterItemInfoWindowTap method could call that private method.
reidbaker
approved these changes
Apr 2, 2026
stuartmorgan-g
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 9, 2026
… callback not firing (flutter/packages#11390)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 9, 2026
… callback not firing (flutter/packages#11390)
github-merge-queue Bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 9, 2026
flutter/packages@0e0a032...1aa892c 2026-04-09 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android] Adds support to opt out of Android inset changes (flutter/packages#11192) 2026-04-08 engine-flutter-autoroll@skia.org Roll Flutter from a0924c7 to 05e0ae0 (24 revisions) (flutter/packages#11470) 2026-04-08 stuartmorgan@google.com [pigeon] Make Kotlin FlutterError a runtime error (flutter/packages#11469) 2026-04-08 stuartmorgan@google.com [path_provider] Remove dependency on engine PathUtils (flutter/packages#11467) 2026-04-07 1063596+reidbaker@users.noreply.github.com [all] Prepare packages for skills (flutter/packages#11430) 2026-04-07 engine-flutter-autoroll@skia.org Roll Flutter from 9cd60b5 to a0924c7 (13 revisions) (flutter/packages#11463) 2026-04-07 elitree@gmail.com [google_maps_flutter] Android cluster pin info window onTap callback not firing (flutter/packages#11390) 2026-04-07 stuartmorgan@google.com [flutter_svg] Remove generated CMake files (flutter/packages#11459) 2026-04-07 stuartmorgan@google.com [various] Convert remaining Groovy files to Kotlin (flutter/packages#11443) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
mbcorona
pushed a commit
to mbcorona/flutter
that referenced
this pull request
Apr 15, 2026
…r#184829) flutter/packages@0e0a032...1aa892c 2026-04-09 10687576+bparrishMines@users.noreply.github.com [webview_flutter_android] Adds support to opt out of Android inset changes (flutter/packages#11192) 2026-04-08 engine-flutter-autoroll@skia.org Roll Flutter from a0924c7 to 05e0ae0 (24 revisions) (flutter/packages#11470) 2026-04-08 stuartmorgan@google.com [pigeon] Make Kotlin FlutterError a runtime error (flutter/packages#11469) 2026-04-08 stuartmorgan@google.com [path_provider] Remove dependency on engine PathUtils (flutter/packages#11467) 2026-04-07 1063596+reidbaker@users.noreply.github.com [all] Prepare packages for skills (flutter/packages#11430) 2026-04-07 engine-flutter-autoroll@skia.org Roll Flutter from 9cd60b5 to a0924c7 (13 revisions) (flutter/packages#11463) 2026-04-07 elitree@gmail.com [google_maps_flutter] Android cluster pin info window onTap callback not firing (flutter/packages#11390) 2026-04-07 stuartmorgan@google.com [flutter_svg] Remove generated CMake files (flutter/packages#11459) 2026-04-07 stuartmorgan@google.com [various] Convert remaining Groovy files to Kotlin (flutter/packages#11443) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in flutter/flutter#184338, Google Maps Flutter Android has an issue where the cluster pin info window doesn't fire the
onTapcallback. That's the info window that shows when you tap a clustered pin (a pin which is part of a cluster manager). While the info window shows properly, theonTapdoesn't fire in Android, but properly fires in other platforms.Fixes flutter/flutter#184338
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2