Skip to content

[ci] use override: post-release-<package> label#11429

Merged
auto-submit[bot] merged 1 commit intoflutter:mainfrom
chunhtai:update-post-release
Apr 6, 2026
Merged

[ci] use override: post-release-<package> label#11429
auto-submit[bot] merged 1 commit intoflutter:mainfrom
chunhtai:update-post-release

Conversation

@chunhtai
Copy link
Copy Markdown
Contributor

@chunhtai chunhtai commented Apr 3, 2026

The ci only capture label that starts with override:. We can either (1) update the ci to capture more labels, or (2) update the post release label to start with override:.

I figured adding override: prefix is more appropriate because the label is attempting to override verision check for batch release.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the version check command to use the label prefix "override: " for post-release checks. Specifically, it modifies the label detection logic in version_check_command.dart and updates the corresponding test cases and descriptions in version_check_command_test.dart. I have no feedback to provide.

@chunhtai chunhtai added the CICD Run CI/CD label Apr 3, 2026
Copy link
Copy Markdown
Collaborator

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 6, 2026
@auto-submit auto-submit bot merged commit ed7881e into flutter:main Apr 6, 2026
81 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 7, 2026
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Apr 8, 2026
flutter/packages@5299279...0e0a032

2026-04-07 stuartmorgan@google.com [various] Ignore generated plugin
files (flutter/packages#11455)
2026-04-06 engine-flutter-autoroll@skia.org Roll Flutter from
7245c3f to 9cd60b5 (30 revisions) (flutter/packages#11452)
2026-04-06 47866232+chunhtai@users.noreply.github.com [go_router]
Manually Sync go_router release to main (flutter/packages#11449)
2026-04-06 10687576+bparrishMines@users.noreply.github.com
[path_provider_android] Changes internal implementation to use JNI
(flutter/packages#9770)
2026-04-06 47866232+chunhtai@users.noreply.github.com [ci] use override:
post-release-<package> label (flutter/packages#11429)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants