[webview_flutter_wkwebview] Tear down ProxyAPIRegistrar in `applicationWillTerminate` by bparrishMines · Pull Request #11567 · flutter/packages

bparrishMines · 2026-04-22T20:53:52Z

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩²

…ar in `a…" This reverts commit 6351fa4.

gemini-code-assist

Code Review

This pull request updates the webview_flutter_wkwebview plugin to version 3.24.6, increases the minimum supported SDK versions to Flutter 3.38 and Dart 3.10, and implements logic to tear down the ProxyAPIRegistrar when the application terminates or a scene disconnects on iOS. Review feedback notes that PlatformViewImplTests.swift is referenced in the project file but missing from the PR, warns that sceneDidDisconnect might prematurely destroy state in multi-scene applications, suggests safer handling of optional scenes in tests, and identifies redundant setup calls in the new test file.

gemini-code-assist · 2026-04-22T21:42:44Z

 		8F1488FF2D2DE27000191744 /* NavigationActionProxyAPITests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 8F1488CB2D2DE27000191744 /* NavigationActionProxyAPITests.swift */; };
 		8F1489012D2DE91C00191744 /* AuthenticationChallengeResponseProxyAPITests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 8F1489002D2DE91C00191744 /* AuthenticationChallengeResponseProxyAPITests.swift */; };
+		8F63D06B2F8812E400EC5076 /* WebViewFlutterPluginTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 8F63D06A2F8812E400EC5076 /* WebViewFlutterPluginTests.swift */; };
+		8F63D06C2F8812E400EC5076 /* PlatformViewImplTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 8F63D0692F8812E400EC5076 /* PlatformViewImplTests.swift */; };


The project file has been updated to include PlatformViewImplTests.swift, but this file is missing from the pull request patches. This will result in a build error in Xcode due to a missing file reference. Please ensure all new test files are included in the commit.

gemini-code-assist · 2026-04-22T21:42:44Z

+    public func sceneDidDisconnect(_ scene: UIScene) {
+      tearDownProxyAPIRegistrar()
+    }


Tearing down the ProxyAPIRegistrar in sceneDidDisconnect may be problematic for applications that support multiple scenes (e.g., on iPad). If one scene is disconnected while others remain active and share the same Flutter engine, the plugin's state will be destroyed for all scenes, potentially breaking the remaining webviews. Since applicationWillTerminate and detachFromEngine already handle cleanup for the app and engine respectively, consider if sceneDidDisconnect is necessary or if it should be removed to avoid side effects in multi-window scenarios.

gemini-code-assist · 2026-04-22T21:42:44Z

+        expectation.fulfill()
+      }
+
+      let scene = UIApplication.shared.connectedScenes.first!


Using a forced unwrap on UIApplication.shared.connectedScenes.first can lead to a crash during test execution if the test environment does not have any active scenes. It is safer to use a guard statement or an optional binding to handle cases where no scenes are connected.

Suggested change

let scene = UIApplication.shared.connectedScenes.first!

guard let scene = UIApplication.shared.connectedScenes.first else {

XCTFail("No connected scenes found.")

return

}

gemini-code-assist · 2026-04-22T21:42:44Z

+  #if os(iOS)
+    func testInstanceManagerIsDeallocatedInApplicationWillTerminate() {
+      let plugin = WebViewFlutterPlugin(binaryMessenger: TestBinaryMessenger())
+      plugin.proxyApiRegistrar!.setUp()


The call to plugin.proxyApiRegistrar!.setUp() is redundant because the WebViewFlutterPlugin initializer already calls setUp() on the registrar. This can be removed to avoid unnecessary re-initialization of the ProxyAPI.

gemini-code-assist · 2026-04-22T21:42:44Z

+
+    func testInstanceManagerIsDeallocatedInSceneDidDisconnect() {
+      let plugin = WebViewFlutterPlugin(binaryMessenger: TestBinaryMessenger())
+      plugin.proxyApiRegistrar!.setUp()


The call to plugin.proxyApiRegistrar!.setUp() is redundant here as well, as the plugin's initializer already handles the setup of the registrar.

stuartmorgan-g · 2026-04-27T18:51:16Z

I just noticed that this is being added to the iOS project but not the macOS project, even though it sounds generic. Someone will almost certainly add tests here in the future thinking they will run on macOS, so the file should be added to both.

I went ahead and added all the tests files not added on macOS.

…minate2

stuartmorgan-g

LGTM

…minate2

…r#185897) flutter/packages@cde5b36...daf30f8 2026-04-30 mdebbar@google.com [url_launcher_web] Re-enable flaky test (not flaky anymore) (flutter/packages#11478) 2026-04-30 stuartmorgan@google.com [in_app_purchase] Switch to Kotlin Pigeon (flutter/packages#11608) 2026-04-29 katelovett@google.com [two_dimensional_scrollables] Fix mouse event loop when calling setState in TableSpan.onEnter (flutter/packages#11606) 2026-04-29 katelovett@google.com [two_dimensional_scrollables] trailing pinned row/col for TableView (flutter/packages#11519) 2026-04-29 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkwebview] Tear down ProxyAPIRegistrar in `applicationWillTerminate` (flutter/packages#11567) 2026-04-29 stuartmorgan@google.com [google_maps_flutter] Replace use of zIndex in examples and tests (flutter/packages#11572) 2026-04-29 stuartmorgan@google.com [tool] Remove --against-pub flag (flutter/packages#11550) 2026-04-29 47866232+chunhtai@users.noreply.github.com [ci] Update branch management for batch release (flutter/packages#11575) 2026-04-29 spkhalad@gmail.com [webview_flutter] Platform implementations for getCookies flutter#11037 (flutter/packages#11386) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bparrishMines added 3 commits April 22, 2026 14:44

Revert "Revert "[webview_flutter_wkwebview] Tear down ProxyAPIRegistr…

edf39b1

…ar in `a…" This reverts commit 6351fa4.

version bump

46de295

version bump

e291901

github-actions Bot added platform-ios platform-macos p: webview_flutter labels Apr 22, 2026

add dart version

44ccc3a

bparrishMines changed the title ~~Wkwebview terminate2~~ [webview_flutter_wkwebview] Prevent message calls when application will terminate Apr 22, 2026

bparrishMines changed the title ~~[webview_flutter_wkwebview] Prevent message calls when application will terminate~~ [webview_flutter_wkwebview] Tear down ProxyAPIRegistrar in applicationWillTerminate Apr 22, 2026

bparrishMines added the CICD Run CI/CD label Apr 22, 2026

bparrishMines marked this pull request as ready for review April 22, 2026 21:40

bparrishMines requested a review from stuartmorgan-g April 22, 2026 21:40

gemini-code-assist Bot reviewed Apr 22, 2026

View reviewed changes

stuartmorgan-g reviewed Apr 23, 2026

View reviewed changes

Comment thread packages/webview_flutter/webview_flutter_wkwebview/pubspec.yaml

stuartmorgan-g requested changes Apr 27, 2026

View reviewed changes

bparrishMines added 3 commits April 27, 2026 14:58

Merge branch 'main' of github.com:flutter/packages into wkwebview_ter…

da61175

…minate2

add tests to macos

b595f99

Merge branch 'main' of github.com:flutter/packages into wkwebview_ter…

5dfba8d

…minate2

github-actions Bot removed the CICD Run CI/CD label Apr 28, 2026

bparrishMines added the CICD Run CI/CD label Apr 28, 2026

bparrishMines requested a review from stuartmorgan-g April 28, 2026 15:11

stuartmorgan-g approved these changes Apr 29, 2026

View reviewed changes

Merge branch 'main' of github.com:flutter/packages into wkwebview_ter…

c933821

…minate2

github-actions Bot removed the CICD Run CI/CD label Apr 29, 2026

bparrishMines added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App labels Apr 29, 2026

auto-submit Bot merged commit e212d61 into flutter:main Apr 29, 2026
83 checks passed

This was referenced Apr 30, 2026

Roll Packages from cde5b36e7ece to c3360ac8ae74 (7 revisions) flutter/flutter#185829

Closed

Roll Packages from cde5b36e7ece to 47cfea4c2a25 (8 revisions) flutter/flutter#185841

Closed

bparrishMines deleted the wkwebview_terminate2 branch April 30, 2026 18:53

engine-flutter-autoroll mentioned this pull request May 1, 2026

Roll Packages from cde5b36e7ece to daf30f846815 (9 revisions) flutter/flutter#185897

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[webview_flutter_wkwebview] Tear down ProxyAPIRegistrar in `applicationWillTerminate`#11567

[webview_flutter_wkwebview] Tear down ProxyAPIRegistrar in `applicationWillTerminate`#11567
auto-submit[bot] merged 8 commits intoflutter:mainfrom
bparrishMines:wkwebview_terminate2

bparrishMines commented Apr 22, 2026 •

edited

Loading

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Apr 22, 2026

Uh oh!

gemini-code-assist Bot Apr 22, 2026

Uh oh!

gemini-code-assist Bot Apr 22, 2026

Uh oh!

gemini-code-assist Bot Apr 22, 2026

Uh oh!

gemini-code-assist Bot Apr 22, 2026

Uh oh!

Uh oh!

stuartmorgan-g Apr 27, 2026

Uh oh!

bparrishMines Apr 28, 2026

Uh oh!

stuartmorgan-g left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-      let scene = UIApplication.shared.connectedScenes.first!
+      guard let scene = UIApplication.shared.connectedScenes.first else {
+        XCTFail("No connected scenes found.")
+        return
+      }

Conversation

bparrishMines commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

stuartmorgan-g Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

bparrishMines Apr 28, 2026

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bparrishMines commented Apr 22, 2026 •

edited

Loading