Trying out go_router support for OpenContainer#11611
Draft
Piinks wants to merge 1 commit intoflutter:mainfrom
Draft
Trying out go_router support for OpenContainer#11611Piinks wants to merge 1 commit intoflutter:mainfrom
Piinks wants to merge 1 commit intoflutter:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design Doc
This PR fixes flutter/flutter#121929 by making the
OpenContainerwidget compatible with declarative routers likego_router.Problem
OpenContainerpreviously hardcoded an imperativeNavigator.pushcall. When used with declarative routers on the web, this prevented the browser URL from updating when the container opened. Manually triggering a router navigation would lose the signature "morphing" animation because the destination page had no metadata about the source widget's position/size.Solution
I have introduced a coordination mechanism that allows the source widget and the destination page to share animation metadata while letting the Router own the navigation state.
Key Changes
Pageclass that can be used inRouterroute definitions.OpenContainerto allow overriding the default imperative push with a declarative navigation call (e.g.,context.go()).Hero.tag) used to link the sourceOpenContainerwith the destinationOpenContainerPage.OpenContainerRouteto handle cases where the source widget is not present (e.g., direct URL deep-linking) by falling back to a smooth fade transition.OpenContainerRouteandHideablepublic to support these new declarative workflows.Usage Example
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2