Skip to content

[flutter_svg] add imageBuilder property to SvgPicture#11615

Open
suojae wants to merge 3 commits intoflutter:mainfrom
suojae:feat/add-svg-picture-image-builder
Open

[flutter_svg] add imageBuilder property to SvgPicture#11615
suojae wants to merge 3 commits intoflutter:mainfrom
suojae:feat/add-svg-picture-image-builder

Conversation

@suojae
Copy link
Copy Markdown
Contributor

@suojae suojae commented Apr 30, 2026 •
edited
Loading

related with flutter/flutter#182635

Adds an imageBuilder property to SvgPicture

Changes

  • Added SvgImageWidgetBuilder.
  • Added imageBuilder to all SvgPicture constructors.
  • Forwarded imageBuilder to createCompatVectorGraphic.
  • Added tests for successful load and placeholder states.
  • Bumped flutter_svg to 2.3.0 and vector_graphics to ^1.2.0.

Pre-Review Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the AI contribution guidelines and understand my responsibilities, or I am not using AI tools.
  • I read the Tree Hygiene page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter.
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets.
  • I linked to at least one issue in the description above.
  • I followed the version and CHANGELOG instructions.
  • I updated/added any relevant documentation.
  • I added new tests to check the change I am making.
  • All existing and new tests are passing.

@github-actions github-actions Bot added p: flutter_svg triage-engine Should be looked at in engine triage labels Apr 30, 2026
@suojae suojae marked this pull request as ready for review April 30, 2026 01:18
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Apr 30, 2026
View reviewed changes
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds an imageBuilder property to the SvgPicture widget, enabling custom wrapping of successfully loaded SVGs. The implementation includes a new SvgImageWidgetBuilder typedef, updates to all SvgPicture constructors, and a version bump to 2.3.0. The vector_graphics dependency is also updated to 1.2.0, supported by new unit tests for the imageBuilder functionality. I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

p: flutter_svg triage-engine Should be looked at in engine triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@suojae