Skip to content

[url_launcher] Remove obsolete LICENSE entry#11631

Open
stuartmorgan-g wants to merge 3 commits intoflutter:mainfrom
stuartmorgan-g:license-check-cleanup
Open

[url_launcher] Remove obsolete LICENSE entry#11631
stuartmorgan-g wants to merge 3 commits intoflutter:mainfrom
stuartmorgan-g:license-check-cleanup

Conversation

@stuartmorgan-g
Copy link
Copy Markdown
Collaborator

@stuartmorgan-g stuartmorgan-g commented May 1, 2026

The third-party code in url_launcher_web was removed in #4330, but we never removed:

  • The top-level LICENSE file entry for that code
  • The repo tooling allowance for that copyright/license

This removes those remaining pieces.

Part of flutter/flutter#129575

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

The third-party code in `google_maps_flutter_web` was removed in
flutter#4330, but we never removed:
- The top-level LICENSE file entry for that code
- The repo tooling allowance for that copyright/license

This removes those remaining pieces.

Part of flutter/flutter#129575
@stuartmorgan-g stuartmorgan-g requested a review from mdebbar May 1, 2026 17:21
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label May 1, 2026
@flutter-dashboard
Copy link
Copy Markdown

This pull request is not mergeable in its current state, likely because of a merge conflict. Pre-submit CI jobs were not triggered. Pushing a new commit to this branch that resolves the issue will result in pre-submit jobs being scheduled.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request increments the version of google_maps_flutter_web to 0.6.2+1 and updates its changelog. However, the license modifications and tool regex removals were applied to url_launcher_web instead of the intended package. Feedback indicates that the wrong license file and regex were likely modified, as the changes do not align with the package being versioned.

Comment thread packages/url_launcher/url_launcher_web/LICENSE
Comment thread script/tool/lib/src/license_check_command.dart
@github-actions github-actions Bot removed the CICD Run CI/CD label May 1, 2026
@stuartmorgan-g stuartmorgan-g changed the title [google_maps_flutter] Remove obsolete LICENSE entry [url_launcher] Remove obsolete LICENSE entry May 1, 2026
@stuartmorgan-g
Copy link
Copy Markdown
Collaborator Author

Trying again, this time without forgetting which of the web packages with third-party code I was actually changing...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant