[camera] Add support for RGBA_8888 image streaming format#11632
[camera] Add support for RGBA_8888 image streaming format#11632Mairramer wants to merge 4 commits intoflutter:mainfrom
Conversation
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces support for the rgba8888 image format across the camera plugin ecosystem, covering the platform interface, Android (CameraX), and iOS (AVFoundation) implementations. The changes include necessary enum additions, mapping logic, Pigeon-generated code updates, and unit tests. Review feedback identifies missing mappings for the Android PixelFormat.RGBA_8888 constant (value 1) in the main package and platform interface. Furthermore, updates to dependency versions in several pubspec.yaml files are required to ensure cross-package compatibility for the new format.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request adds support for the rgba8888 image format across the camera plugin and its federated implementations for Android (CameraX) and iOS (AVFoundation). The changes include updating the platform interface, adding format mappings in the native implementations, and bumping package versions. Feedback was provided regarding a potential mismatch in Android format codes where PixelFormat.RGBA_8888 (1) should be supported alongside ImageFormat.FLEX_RGBA_8888 (42) for consistency, and a minor documentation fix was suggested for a constant name.
There was a problem hiding this comment.
Code Review
This pull request adds support for the rgba8888 image format across the camera plugin ecosystem, including the platform interface, Android (CameraX), and iOS (AVFoundation) implementations. The changes include updating the ImageFormatGroup enum, implementing format mapping logic in Dart and native code, and adding corresponding unit tests. Additionally, Pigeon-generated files were updated to a newer version, and temporary dependency overrides were included for testing. I have no feedback to provide.
This PR adds support for the rgba8888 image format group for both Android (
camera_android_camerax) and iOS (camera_avfoundation).Closes flutter/flutter#151193
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2