Skip to content

[material_ui] Port PR (#184807) from flutter/flutter to material_ui #11972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 1 commit into from
Jun 29, 2026
+32 −50
Merged

[material_ui] Port PR (#184807) from flutter/flutter to material_ui #11972

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 32 additions & 50 deletions packages/material_ui/test/material_button_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@ import 'package:flutter/rendering.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:material_ui/material_ui.dart';

import 'semantics_tester.dart';

void main() {
setUp(() {
debugResetSemanticsIdCounter();
Expand Down Expand Up @@ -637,15 +635,13 @@ void main() {
testWidgets(
'Disabled MaterialButton has same semantic size as enabled and exposes disabled semantics',
(WidgetTester tester) async {
final semantics = SemanticsTester(tester);

const expectedButtonSize = Rect.fromLTRB(0.0, 0.0, 116.0, 48.0);
// Button is in center of screen
final expectedButtonTransform = Matrix4.identity()
..translate(
TestSemantics.fullScreen.width / 2 - expectedButtonSize.width / 2,
TestSemantics.fullScreen.height / 2 - expectedButtonSize.height / 2,
);
const expectedButtonSize = Size(116.0, 48.0);
// Button is in center of the 800x600 test screen.
final expectedButtonTransform = Matrix4.diagonal3Values(
tester.view.devicePixelRatio,
tester.view.devicePixelRatio,
1.0,
)..translate(400.0 - expectedButtonSize.width / 2, 300.0 - expectedButtonSize.height / 2);

// enabled button
await tester.pumpWidget(
Expand All @@ -665,28 +661,21 @@ void main() {
),
);

final SemanticsNode enabledSemantics = tester.getSemantics(find.byType(MaterialButton));
expect(
semantics,
hasSemantics(
TestSemantics.root(
children: <TestSemantics>[
TestSemantics.rootChild(
id: 1,
rect: expectedButtonSize,
transform: expectedButtonTransform,
label: 'Button',
actions: <SemanticsAction>[SemanticsAction.tap, SemanticsAction.focus],
flags: <SemanticsFlag>[
SemanticsFlag.hasEnabledState,
SemanticsFlag.isButton,
SemanticsFlag.isEnabled,
SemanticsFlag.isFocusable,
],
),
],
),
enabledSemantics,
matchesSemantics(
label: 'Button',
hasTapAction: true,
hasFocusAction: true,
hasEnabledState: true,
isButton: true,
isEnabled: true,
isFocusable: true,
size: expectedButtonSize,
),
);
expect(enabledSemantics.transform, expectedButtonTransform);

// disabled button
await tester.pumpWidget(
Expand All @@ -704,29 +693,22 @@ void main() {
),
);

final SemanticsNode disabledSemantics = tester.getSemantics(find.byType(MaterialButton));
expect(
semantics,
hasSemantics(
TestSemantics.root(
children: <TestSemantics>[
TestSemantics.rootChild(
id: 1,
rect: expectedButtonSize,
transform: expectedButtonTransform,
label: 'Button',
flags: <SemanticsFlag>[
SemanticsFlag.hasEnabledState,
SemanticsFlag.isButton,
SemanticsFlag.isFocusable,
],
actions: <SemanticsAction>[SemanticsAction.focus],
),
],
),
disabledSemantics,
matchesSemantics(
label: 'Button',
hasFocusAction: true,
hasEnabledState: true,
isButton: true,
isFocusable: true,
size: expectedButtonSize,
),
);

semantics.dispose();
expect(disabledSemantics.transform, expectedButtonTransform);
final SemanticsData semanticsData = disabledSemantics.getSemanticsData();
expect(semanticsData.hasFlag(SemanticsFlag.isEnabled), isFalse);
expect(semanticsData.hasAction(SemanticsAction.tap), isFalse);
Comment on lines +709 to +711

@gemini-code-assist gemini-code-assist Bot Jun 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

In Flutter's matchesSemantics matcher, any boolean flags (such as isEnabled) and actions (such as hasTapAction) that are not explicitly specified default to false. Since matchesSemantics already asserts that these properties are absent, these manual assertions on SemanticsData are redundant and can be safely removed.

@Piinks Piinks Jun 29, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think redundancy like this is ok in tests. Super verified. :)

},
);

Expand Down
Loading