Skip to content

[cupertino_ui] Migrate segmented_control_test.dart to SemanticsHandle#11982

Merged
auto-submit[bot] merged 3 commits into
flutter:mainfrom
Renzo-Olivares:cupertino_ui_segmented_control_test_migration
Jul 1, 2026
Merged

[cupertino_ui] Migrate segmented_control_test.dart to SemanticsHandle#11982
auto-submit[bot] merged 3 commits into
flutter:mainfrom
Renzo-Olivares:cupertino_ui_segmented_control_test_migration

Conversation

@Renzo-Olivares

@Renzo-Olivares Renzo-Olivares commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Part of flutter/flutter#182636 and flutter/flutter#188395

This PR:

  • Removed the cross-import of widgets/semantics_tester.dart. Replaced SemanticsTester with SemanticsHandle.
  • Removed @Skip annotation, all tests in this file has passed. semantics_tester.dart has existed in cupertino_ui, so we can directly import semantics_tester.dart;
  • Moved the file to test/ folder.

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jun 25, 2026
@github-actions github-actions Bot added the triage-framework Should be looked at in framework triage label Jun 25, 2026
@Renzo-Olivares Renzo-Olivares mentioned this pull request Jun 25, 2026
Open
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jun 25, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request unskips the segmented control test file and refactors the semantics test to use SemanticsHandle and individual semantics assertions instead of SemanticsTester. The reviewer identified that find.semantics is not a valid property on CommonFinders and recommended using find.bySemanticsLabel instead for the assertions.

Comment thread packages/cupertino_ui/test/segmented_control_test.dart
ignoreId: true,
ignoreRect: true,
ignoreTransform: true,
find.semantics.byLabel('Child 1'),

@gemini-code-assist gemini-code-assist Bot Jun 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The find.semantics property does not exist on CommonFinders. To find a widget by its semantics label, use find.bySemanticsLabel instead.

      find.bySemanticsLabel('Child 1'),

@Renzo-Olivares Renzo-Olivares Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

find.semantics does exist.

Comment thread packages/cupertino_ui/test/segmented_control_test.dart

// Assert Child 2 (unselected)
expect(
find.semantics.byLabel('Child 2'),

@gemini-code-assist gemini-code-assist Bot Jun 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The find.semantics property does not exist on CommonFinders. To find a widget by its semantics label, use find.bySemanticsLabel instead.

      find.bySemanticsLabel('Child 2'),

@Renzo-Olivares Renzo-Olivares Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

find.semantics does exist.

Comment thread packages/cupertino_ui/test/segmented_control_test.dart
ignoreId: true,
ignoreRect: true,
ignoreTransform: true,
find.semantics.byLabel('Child 1'),

@gemini-code-assist gemini-code-assist Bot Jun 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The find.semantics property does not exist on CommonFinders. To find a widget by its semantics label, use find.bySemanticsLabel instead.

      find.bySemanticsLabel('Child 1'),

@Renzo-Olivares Renzo-Olivares Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

find.semantics does exist.

Comment thread packages/cupertino_ui/test/segmented_control_test.dart

// Assert Child 2 (now selected and focused)
expect(
find.semantics.byLabel('Child 2'),

@gemini-code-assist gemini-code-assist Bot Jun 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The find.semantics property does not exist on CommonFinders. To find a widget by its semantics label, use find.bySemanticsLabel instead.

      find.bySemanticsLabel('Child 2'),

@Renzo-Olivares Renzo-Olivares Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

find.semantics does exist.

@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 25, 2026
@Renzo-Olivares Renzo-Olivares added the CICD Run CI/CD label Jun 25, 2026
@Renzo-Olivares Renzo-Olivares mentioned this pull request Jun 25, 2026
Closed
@Piinks Piinks changed the title [Decoupling] Migrate segmented_control_test.dart to SemanticsHandle [cupertino_ui] Migrate segmented_control_test.dart to SemanticsHandle Jun 25, 2026
justinmc
justinmc approved these changes Jun 30, 2026
View reviewed changes

@justinmc justinmc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus ensureSemantics 👍

Comment thread packages/cupertino_ui/test/segmented_control_test.dart Outdated

testWidgets('Segmented control semantics', (WidgetTester tester) async {
final semantics = SemanticsTester(tester);
final SemanticsHandle handle = tester.ensureSemantics();

@justinmc justinmc Jun 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ensureSemantics is not needed.

@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 30, 2026
@Renzo-Olivares Renzo-Olivares added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App labels Jun 30, 2026
@auto-submit auto-submit Bot merged commit 99a427a into flutter:main Jul 1, 2026
88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD p: cupertino_ui triage-framework Should be looked at in framework triage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Renzo-Olivares @justinmc @Piinks