Skip to content

[material_ui] Enable chip_test#12009

Merged
auto-submit[bot] merged 2 commits into
flutter:mainfrom
elliette:pr184297/chip-test
Jun 29, 2026
Merged

[material_ui] Enable chip_test#12009
auto-submit[bot] merged 2 commits into
flutter:mainfrom
elliette:pr184297/chip-test

Conversation

@elliette

@elliette elliette commented Jun 25, 2026

Copy link
Copy Markdown
Member

Port over chip_test from flutter/flutter#184279

Work towards flutter/flutter#182636 and flutter/flutter#188395

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jun 25, 2026
@github-actions github-actions Bot added triage-framework Should be looked at in framework triage p: material_ui labels Jun 25, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes @Skip annotations from several test files, reorganizes imports, and extracts the findByTooltip finder and FeedbackTester helper into standalone test utility files (finders.dart and feedback_tester.dart) to resolve cross-import issues. Feedback is provided to use optional chaining instead of a null assertion operator on widget.richMessage in finders.dart to avoid potential runtime exceptions.

Comment thread packages/material_ui/test/finders.dart
@elliette elliette marked this pull request as draft June 26, 2026 18:02
@elliette elliette force-pushed the pr184297/chip-test branch from 003a9d4 to 0492e1d Compare June 26, 2026 18:22
@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 26, 2026
@elliette elliette force-pushed the pr184297/chip-test branch from 0492e1d to 56ce5d7 Compare June 26, 2026 23:07
@elliette elliette added the CICD Run CI/CD label Jun 26, 2026
@elliette elliette marked this pull request as ready for review June 26, 2026 23:08

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the @Skip annotation from chip_test.dart, fixes cross-imports by updating relative paths, and wraps a thrown multiline string in an Exception object. The review feedback suggests refactoring the multiline string exception message to avoid preserving accidental leading whitespace, recommending adjacent string literals with explicit newlines instead.

Comment on lines +203 to +205
throw Exception('''
Expected: center == $expectedCenter, radius == $expectedRadius
Found: center == $center radius == $radius''';
Found: center == $center radius == $radius''');

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The multiline string literal preserves the leading whitespace (14 spaces) on each line, which will make the exception message heavily indented and hard to read in test failure logs.

Using adjacent string literals with explicit \n avoids accidental leading whitespace while keeping the code clean and readable.

    throw Exception(
      'Expected: center == $expectedCenter, radius == $expectedRadius\n'
      'Found: center == $center radius == $radius',
    );

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 29, 2026
@auto-submit auto-submit Bot merged commit 6e16ed6 into flutter:main Jun 29, 2026
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD p: material_ui triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants