[material_ui] Enable floating_action_button_test#12014
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes the @Skip annotations from several test files, refactors imports to use local paths, and extracts the shared findByTooltip helper function into a new finders.dart file. Feedback on the changes suggests using optional chaining instead of a null assertion operator on widget.richMessage in findByTooltip to prevent a potential runtime exception when both message and richMessage are null.
90f9f89 to
cd23efc
Compare
There was a problem hiding this comment.
Code Review
This pull request removes the @Skip annotation from floating_action_button_test.dart, imports dart:async, reorders the imports, and wraps several Navigator.push calls in unawaited to handle unawaited futures. There are no review comments, and I have no feedback to provide.
d57c88e to
4b7c1fe
Compare
4b7c1fe to
4e13c8b
Compare
Port over
floating_action_button_testfrom flutter/flutter#184279Work towards flutter/flutter#182636 and flutter/flutter#188395
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2