Skip to content

[material_ui] Remove widgets/clipboard_utils.dart imports from date_picker_test.dart, input_date_picker_form_field_test.dart, search_test.dart, selectable_text_test.dart, text_form_field_test.dart, text_selection_test.dart#12030

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
QuncCccccc:enable_material_text_selection_depend_12022
Jun 29, 2026

Conversation

@QuncCccccc

@QuncCccccc QuncCccccc commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Test failures are expected. This PR should land after #12022

Part of flutter/flutter#182636 and flutter/flutter#188395

This PR:

  • Removed the cross-import of widgets/clipboard_utils.dart.
  • Removed @Skip tag, all tests in this file has passed. semantics_tester.dart has existed in material_ui, so we can directly import semantics_tester.dart;
  • Moved the file to test/ folder.

This PR is to port over the changes in flutter/flutter#184278

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jun 26, 2026
@github-actions github-actions Bot added triage-framework Should be looked at in framework triage p: material_ui labels Jun 26, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the @Skip annotations from multiple test files in packages/material_ui/test/, including date_picker_test.dart, input_date_picker_form_field_test.dart, search_test.dart, selectable_text_test.dart, text_form_field_test.dart, and text_selection_test.dart. Additionally, it updates relative imports to local imports, reorganizes import statements, and wraps asynchronous showDatePicker calls in unawaited within date_picker_test.dart. There are no review comments, and I have no feedback to provide.

@QuncCccccc QuncCccccc force-pushed the enable_material_text_selection_depend_12022 branch from 1387658 to 72dd7c2 Compare June 29, 2026 17:24
@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 29, 2026
@QuncCccccc QuncCccccc requested review from Piinks and justinmc June 29, 2026 17:30

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Piinks Piinks added autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD labels Jun 29, 2026
@auto-submit auto-submit Bot merged commit d974a0c into flutter:main Jun 29, 2026
88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD p: material_ui triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants