Skip to content

[material_ui] Remove widgets import in data_table_test.dart, switch_test.dart and tooltip_theme_test.dart#12031

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
QuncCccccc:enable_material_existing_utils_tests
Jun 29, 2026
Merged

[material_ui] Remove widgets import in data_table_test.dart, switch_test.dart and tooltip_theme_test.dart#12031
auto-submit[bot] merged 1 commit into
flutter:mainfrom
QuncCccccc:enable_material_existing_utils_tests

Conversation

@QuncCccccc

Copy link
Copy Markdown
Contributor

Part of flutter/flutter#182636 and flutter/flutter#188395

This PR:

  • Removed the cross-import of widgets/semantics_tester.dart.
  • Removed @Skip tag, all tests in this file has passed. semantics_tester.dart has existed in material_ui, so we can directly import semantics_tester.dart;
  • Moved the file to test/ folder.

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jun 26, 2026
@github-actions github-actions Bot added triage-framework Should be looked at in framework triage p: material_ui labels Jun 26, 2026
@QuncCccccc QuncCccccc requested a review from Piinks June 26, 2026 22:24

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the @Skip annotations from data_table_test.dart, switch_test.dart, and tooltip_theme_test.dart in the material_ui package, re-enabling these test files. It also reorganizes the import statements in these files, including updating the import path for semantics_tester.dart from a relative parent directory to a local directory. There are no review comments, and no further feedback is provided.

@QuncCccccc QuncCccccc requested a review from justinmc June 26, 2026 22:24

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 29, 2026
@auto-submit auto-submit Bot merged commit 523fff0 into flutter:main Jun 29, 2026
87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD p: material_ui triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants