Skip to content

[cupertino_ui] Re-enable tab_scaffold_test.dart#12064

Open
Renzo-Olivares wants to merge 2 commits into
flutter:mainfrom
Renzo-Olivares:cupertino_ui_tab_scaffold_rendering_removal
Open

[cupertino_ui] Re-enable tab_scaffold_test.dart#12064
Renzo-Olivares wants to merge 2 commits into
flutter:mainfrom
Renzo-Olivares:cupertino_ui_tab_scaffold_rendering_removal

Conversation

@Renzo-Olivares

Copy link
Copy Markdown
Contributor

This test re-enables tab_scaffold_test.dart, and brings over widget_inspector_test_utils.dart into tests/.

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jun 29, 2026
@github-actions github-actions Bot added triage-framework Should be looked at in framework triage p: cupertino_ui labels Jun 29, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the skip annotation from tab_scaffold_test.dart, updates its imports, and introduces a new test utility file widget_inspector_test_utils.dart containing DispatchedEventKey and TestWidgetInspectorService. Feedback suggests removing an unused import in the new utility file and replacing it with package:flutter/widgets.dart. Additionally, it is recommended to use .toString() instead of a direct cast to String in testBoolExtension to handle boolean values safely.


import 'dart:convert';

import 'package:cupertino_ui/cupertino_ui.dart';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The import of package:cupertino_ui/cupertino_ui.dart is unused in this test utility file. To avoid unnecessary coupling and keep the test utilities clean, import package:flutter/widgets.dart instead, which provides WidgetInspectorService and WidgetsBinding.

Suggested change
import 'package:cupertino_ui/cupertino_ui.dart';
import 'package:flutter/widgets.dart';
References
  1. Unused imports should be avoided to keep the codebase clean and maintainable, adhering to Dart's standard lint rules (unused_import). (link)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really unused?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it's definitely used.

Comment on lines +93 to +100
Future<String> testBoolExtension(String name, Map<String, String> arguments) async {
expect(extensions, contains(name));
// Encode and decode to JSON to match behavior using a real service
// extension where only JSON is allowed.
return (json.decode(json.encode(await extensions[name]!(arguments)))
as Map<String, dynamic>)['enabled']
as String;
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The testBoolExtension method casts the 'enabled' value directly to String using as String. However, some service extensions return actual boolean values (e.g., true or false) rather than string representations. To make this utility more robust and prevent runtime TypeErrors, convert the value to a string using .toString().

  Future<String> testBoolExtension(String name, Map<String, String> arguments) async {
    expect(extensions, contains(name));
    // Encode and decode to JSON to match behavior using a real service
    // extension where only JSON is allowed.
    final Map<String, dynamic> result = json.decode(json.encode(await extensions[name]!(arguments))) as Map<String, dynamic>;
    return result['enabled']?.toString() ?? 'false';
  }

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable, though I know you just copied this code, so it's fine either way.

@justinmc justinmc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍


import 'dart:convert';

import 'package:cupertino_ui/cupertino_ui.dart';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really unused?

Comment on lines +93 to +100
Future<String> testBoolExtension(String name, Map<String, String> arguments) async {
expect(extensions, contains(name));
// Encode and decode to JSON to match behavior using a real service
// extension where only JSON is allowed.
return (json.decode(json.encode(await extensions[name]!(arguments)))
as Map<String, dynamic>)['enabled']
as String;
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable, though I know you just copied this code, so it's fine either way.

@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p: cupertino_ui triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants