[cupertino_ui] Migrate checkbox_test.dart to SemanticsHandle#12065
Open
QuncCccccc wants to merge 1 commit into
Open
[cupertino_ui] Migrate checkbox_test.dart to SemanticsHandle#12065QuncCccccc wants to merge 1 commit into
QuncCccccc wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the skip annotation from checkbox_test.dart and refactors the semantics tests to use tester.ensureSemantics() and matchesSemantics instead of SemanticsTester. The reviewer feedback recommends replacing the fragile find.byType(Focus).last finder with a more robust scoped descendant finder to target the Focus widget associated with CupertinoCheckbox.
f1b7719 to
ef99acd
Compare
ef99acd to
d763ace
Compare
chunhtai
reviewed
Jun 30, 2026
|
|
||
| testWidgets('has semantics for tristate', (WidgetTester tester) async { | ||
| final semantics = SemanticsTester(tester); | ||
| final SemanticsHandle handle = tester.ensureSemantics(); |
| }, | ||
| ); | ||
| final semanticsTester = SemanticsTester(tester); | ||
| final SemanticsHandle handle = tester.ensureSemantics(); |
d763ace to
2103776
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of flutter/flutter#182636 and flutter/flutter#188395
This PR:
widgets/semantics_tester.dartfromcheckbox_test.dart.SemanticsTesterusages withSemanticsHandleand directtester.getSemanticsexpectations.@Skipannotation and moves the file to thetest/folder.Pre-Review Checklist
[shared_preferences]///).