Skip to content

[cupertino_ui] Migrate checkbox_test.dart to SemanticsHandle#12065

Open
QuncCccccc wants to merge 1 commit into
flutter:mainfrom
QuncCccccc:enable_cupertino_checkbox_test
Open

[cupertino_ui] Migrate checkbox_test.dart to SemanticsHandle#12065
QuncCccccc wants to merge 1 commit into
flutter:mainfrom
QuncCccccc:enable_cupertino_checkbox_test

Conversation

@QuncCccccc

@QuncCccccc QuncCccccc commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Part of flutter/flutter#182636 and flutter/flutter#188395

This PR:

  • Removes the cross-import of widgets/semantics_tester.dart from checkbox_test.dart.
  • Replaces the remaining SemanticsTester usages with SemanticsHandle and direct tester.getSemantics expectations.
  • Removes the @Skip annotation and moves the file to the test/ folder.

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jun 30, 2026
@github-actions github-actions Bot added triage-framework Should be looked at in framework triage p: cupertino_ui labels Jun 30, 2026
@QuncCccccc QuncCccccc requested review from chunhtai and justinmc June 30, 2026 00:08

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the skip annotation from checkbox_test.dart and refactors the semantics tests to use tester.ensureSemantics() and matchesSemantics instead of SemanticsTester. The reviewer feedback recommends replacing the fragile find.byType(Focus).last finder with a more robust scoped descendant finder to target the Focus widget associated with CupertinoCheckbox.

Comment thread packages/cupertino_ui/test/checkbox_test.dart Outdated
Comment thread packages/cupertino_ui/test/checkbox_test.dart Outdated
Comment thread packages/cupertino_ui/test/checkbox_test.dart Outdated
@QuncCccccc QuncCccccc force-pushed the enable_cupertino_checkbox_test branch from f1b7719 to ef99acd Compare June 30, 2026 00:12
@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 30, 2026
@QuncCccccc QuncCccccc added the CICD Run CI/CD label Jun 30, 2026
@QuncCccccc QuncCccccc force-pushed the enable_cupertino_checkbox_test branch from ef99acd to d763ace Compare June 30, 2026 00:34
@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 30, 2026

testWidgets('has semantics for tristate', (WidgetTester tester) async {
final semantics = SemanticsTester(tester);
final SemanticsHandle handle = tester.ensureSemantics();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed

},
);
final semanticsTester = SemanticsTester(tester);
final SemanticsHandle handle = tester.ensureSemantics();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@QuncCccccc QuncCccccc force-pushed the enable_cupertino_checkbox_test branch from d763ace to 2103776 Compare June 30, 2026 00:43

@justinmc justinmc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minus @chunhtai's point about ensureSemantics 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p: cupertino_ui triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants