Skip to content

[cupertino_ui] Re-enable text_field_test.dart#12067

Open
Renzo-Olivares wants to merge 5 commits into
flutter:mainfrom
Renzo-Olivares:cupertino_ui_text_field_test_enable
Open

[cupertino_ui] Re-enable text_field_test.dart#12067
Renzo-Olivares wants to merge 5 commits into
flutter:mainfrom
Renzo-Olivares:cupertino_ui_text_field_test_enable

Conversation

@Renzo-Olivares

Copy link
Copy Markdown
Contributor

Part of flutter/flutter#182636 and flutter/flutter#188395

This PR:

  • Removed the cross-import of widgets/semantics_tester.dart. Replaced SemanticsTester with SemanticsHandle.
  • Copy/paste helper methods from widgets/text_selection_toolbar_utils.dart to our local copy.
  • Removed @Skip annotation, all tests in this file has passed. semantics_tester.dart has existed in cupertino_ui, so we can directly import semantics_tester.dart;
  • Moved the file to test/ folder.

Pre-Review Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools.
  • I read the [Tree Hygiene] page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter].
  • I signed the [CLA].
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I [linked to at least one issue that this PR fixes] in the description above.
  • I followed [the version and CHANGELOG instructions], using [semantic versioning] and the [repository CHANGELOG style], or I have commented below to indicate which documented exception this PR falls under[^1].
  • I updated/added any relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or I have commented below to indicate which [test exemption] this PR falls under[^1].
  • All existing and new tests are passing.

Renzo Olivares added 4 commits June 29, 2026 23:42
Add missing helper functions from the Flutter framework to support text field tests.

TAG=agy
CONV=eaf9ac41-f14c-4263-8856-55084f46e5db
Remove @Skip and move the file from temporarily_disabled_tests/ to test/.

TAG=agy
CONV=eaf9ac41-f14c-4263-8856-55084f46e5db
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jun 30, 2026
@github-actions github-actions Bot added triage-framework Should be looked at in framework triage p: cupertino_ui labels Jun 30, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the skip annotation from text_field_test.dart and refactors its semantics tests to use tester.ensureSemantics() and isSemantics assertions instead of SemanticsTester and hasSemantics. Additionally, it updates relative imports and introduces helper functions in text_selection_toolbar_utils.dart to verify Cupertino text selection toolbars across different target platforms. No review comments were provided, and there is no additional feedback.

@github-actions github-actions Bot removed the CICD Run CI/CD label Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p: cupertino_ui triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant