[cupertino_ui] Re-enable text_field_test.dart#12067
Open
Renzo-Olivares wants to merge 5 commits into
Open
Conversation
added 4 commits
June 29, 2026 23:42
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the skip annotation from text_field_test.dart and refactors its semantics tests to use tester.ensureSemantics() and isSemantics assertions instead of SemanticsTester and hasSemantics. Additionally, it updates relative imports and introduces helper functions in text_selection_toolbar_utils.dart to verify Cupertino text selection toolbars across different target platforms. No review comments were provided, and there is no additional feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of flutter/flutter#182636 and flutter/flutter#188395
This PR:
widgets/semantics_tester.dart. ReplacedSemanticsTesterwithSemanticsHandle.widgets/text_selection_toolbar_utils.dartto our local copy.@Skipannotation, all tests in this file has passed.semantics_tester.darthas existed incupertino_ui, so we can directly importsemantics_tester.dart;test/folder.Pre-Review Checklist
[shared_preferences]///).