Skip to content

Commit 6a3ffef

Browse files
committed
refactor: clean up unused imports, remove TODO comments, and format code across samples
1 parent 2aedc31 commit 6a3ffef

25 files changed

Lines changed: 50 additions & 125 deletions

File tree

add_to_app/books/flutter_module_books/lib/main.dart

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,8 +66,6 @@ class _BookDetailState extends State<BookDetail> {
6666

6767
// Registering this `FlutterBookApiHandler` class lets us receive incoming
6868
// calls from the platform.
69-
// TODO(gaaclarke): make the setup method an instance method so it's
70-
// injectable https://github.com/flutter/flutter/issues/59119.
7169
FlutterBookApi.setup(
7270
FlutterBookApiHandler(
7371
// The `FlutterBookApi` just has one method. Just give a closure for that
@@ -82,7 +80,6 @@ class _BookDetailState extends State<BookDetail> {
8280
this.book!.title = titleTextController.text;
8381
});
8482
// Subtitle could be null.
85-
// TODO(gaaclarke): https://github.com/flutter/flutter/issues/59118.
8683
subtitleTextController.text = book.subtitle ?? '';
8784
subtitleTextController.addListener(() {
8885
this.book!.subtitle = subtitleTextController.text;

cupertino_gallery/lib/gallery_home.dart

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,11 @@ class GalleryHome extends StatelessWidget {
3737
return switch (index) {
3838
0 => const WidgetsPage(),
3939
1 => SettingsPage(
40-
onThemeChange: onThemeChange,
41-
isDarkMode: isDarkMode,
42-
onTextSizeChange: onTextSizeChange,
43-
textSize: textSize,
44-
),
40+
onThemeChange: onThemeChange,
41+
isDarkMode: isDarkMode,
42+
onTextSizeChange: onTextSizeChange,
43+
textSize: textSize,
44+
),
4545
_ => const Center(child: Text('Widgets')),
4646
};
4747
},

cupertino_gallery/lib/main.dart

Lines changed: 21 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -37,24 +37,31 @@ class _CupertinoGalleryAppState extends State<CupertinoGalleryApp> {
3737
@override
3838
Widget build(BuildContext context) {
3939
final baseTheme = CupertinoThemeData(
40-
brightness:
41-
_themeMode == ThemeMode.dark ? Brightness.dark : Brightness.light,
40+
brightness: _themeMode == ThemeMode.dark
41+
? Brightness.dark
42+
: Brightness.light,
4243
);
4344
final textTheme = baseTheme.textTheme.copyWith(
44-
textStyle:
45-
baseTheme.textTheme.textStyle.copyWith(fontSize: 14 * _textSize),
46-
actionTextStyle: baseTheme.textTheme.actionTextStyle
47-
.copyWith(fontSize: 14 * _textSize),
48-
tabLabelTextStyle: baseTheme.textTheme.tabLabelTextStyle
49-
.copyWith(fontSize: 10 * _textSize),
50-
navTitleTextStyle: baseTheme.textTheme.navTitleTextStyle
51-
.copyWith(fontSize: 17 * _textSize),
45+
textStyle: baseTheme.textTheme.textStyle.copyWith(
46+
fontSize: 14 * _textSize,
47+
),
48+
actionTextStyle: baseTheme.textTheme.actionTextStyle.copyWith(
49+
fontSize: 14 * _textSize,
50+
),
51+
tabLabelTextStyle: baseTheme.textTheme.tabLabelTextStyle.copyWith(
52+
fontSize: 10 * _textSize,
53+
),
54+
navTitleTextStyle: baseTheme.textTheme.navTitleTextStyle.copyWith(
55+
fontSize: 17 * _textSize,
56+
),
5257
navLargeTitleTextStyle: baseTheme.textTheme.navLargeTitleTextStyle
5358
.copyWith(fontSize: 34 * _textSize),
54-
navActionTextStyle: baseTheme.textTheme.navActionTextStyle
55-
.copyWith(fontSize: 17 * _textSize),
56-
pickerTextStyle: baseTheme.textTheme.pickerTextStyle
57-
.copyWith(fontSize: 21 * _textSize),
59+
navActionTextStyle: baseTheme.textTheme.navActionTextStyle.copyWith(
60+
fontSize: 17 * _textSize,
61+
),
62+
pickerTextStyle: baseTheme.textTheme.pickerTextStyle.copyWith(
63+
fontSize: 21 * _textSize,
64+
),
5865
dateTimePickerTextStyle: baseTheme.textTheme.dateTimePickerTextStyle
5966
.copyWith(fontSize: 21 * _textSize),
6067
);

cupertino_gallery/lib/settings_page.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,4 +140,3 @@ class _SettingsPageState extends State<SettingsPage> {
140140
);
141141
}
142142
}
143-

cupertino_gallery/lib/widgets/action_sheet_page.dart

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,7 @@ class ActionSheetPage extends StatelessWidget {
66
@override
77
Widget build(BuildContext context) {
88
return CupertinoPageScaffold(
9-
navigationBar: const CupertinoNavigationBar(
10-
middle: Text('Action Sheet'),
11-
),
9+
navigationBar: const CupertinoNavigationBar(middle: Text('Action Sheet')),
1210
child: Center(
1311
child: CupertinoButton(
1412
child: const Text('Show Action Sheet'),
@@ -30,7 +28,7 @@ class ActionSheetPage extends StatelessWidget {
3028
onPressed: () {
3129
Navigator.pop(context);
3230
},
33-
)
31+
),
3432
],
3533
cancelButton: CupertinoActionSheetAction(
3634
isDefaultAction: true,

cupertino_gallery/lib/widgets/activity_indicator_page.dart

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,8 @@ class ActivityIndicatorPage extends StatelessWidget {
66
@override
77
Widget build(BuildContext context) {
88
return const CupertinoPageScaffold(
9-
navigationBar: CupertinoNavigationBar(
10-
middle: Text('Activity Indicator'),
11-
),
12-
child: Center(
13-
child: CupertinoActivityIndicator(),
14-
),
9+
navigationBar: CupertinoNavigationBar(middle: Text('Activity Indicator')),
10+
child: Center(child: CupertinoActivityIndicator()),
1511
);
1612
}
1713
}

cupertino_gallery/lib/widgets/checkbox_page.dart

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,7 @@ class _CheckboxPageState extends State<CheckboxPage> {
1313
@override
1414
Widget build(BuildContext context) {
1515
return CupertinoPageScaffold(
16-
navigationBar: const CupertinoNavigationBar(
17-
middle: Text('Checkbox'),
18-
),
16+
navigationBar: const CupertinoNavigationBar(middle: Text('Checkbox')),
1917
child: Center(
2018
child: CupertinoCheckbox(
2119
value: _value,

cupertino_gallery/lib/widgets/date_picker_page.dart

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,11 @@ class DatePickerPage extends StatelessWidget {
66
@override
77
Widget build(BuildContext context) {
88
return CupertinoPageScaffold(
9-
navigationBar: const CupertinoNavigationBar(
10-
middle: Text('Date Picker'),
11-
),
9+
navigationBar: const CupertinoNavigationBar(middle: Text('Date Picker')),
1210
child: Center(
1311
child: SizedBox(
1412
height: 200,
15-
child: CupertinoDatePicker(
16-
onDateTimeChanged: (DateTime newDate) {},
17-
),
13+
child: CupertinoDatePicker(onDateTimeChanged: (DateTime newDate) {}),
1814
),
1915
),
2016
);

cupertino_gallery/lib/widgets/picker_page.dart

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,20 +6,14 @@ class PickerPage extends StatelessWidget {
66
@override
77
Widget build(BuildContext context) {
88
return CupertinoPageScaffold(
9-
navigationBar: const CupertinoNavigationBar(
10-
middle: Text('Picker'),
11-
),
9+
navigationBar: const CupertinoNavigationBar(middle: Text('Picker')),
1210
child: Center(
1311
child: SizedBox(
1412
height: 200,
1513
child: CupertinoPicker(
1614
itemExtent: 32,
1715
onSelectedItemChanged: (int index) {},
18-
children: const <Widget>[
19-
Text('One'),
20-
Text('Two'),
21-
Text('Three'),
22-
],
16+
children: const <Widget>[Text('One'), Text('Two'), Text('Three')],
2317
),
2418
),
2519
),

cupertino_gallery/lib/widgets/search_text_field_page.dart

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,7 @@ class SearchTextFieldPage extends StatelessWidget {
66
@override
77
Widget build(BuildContext context) {
88
return const CupertinoPageScaffold(
9-
navigationBar: CupertinoNavigationBar(
10-
middle: Text('Search Text Field'),
11-
),
9+
navigationBar: CupertinoNavigationBar(middle: Text('Search Text Field')),
1210
child: Center(
1311
child: Padding(
1412
padding: EdgeInsets.all(16.0),

0 commit comments

Comments
 (0)