Skip to content

Add a missing import and a note about an edge-case crash #13247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sfshaza2 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add a missing import and a note about an edge-case crash #13247

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60ba917
Add a missing import and a note about an edge-case crash
sfshaza2 Apr 2, 2026
0bc91a5
Incorporating feedback
sfshaza2 Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/content/learn/pathway/tutorial/navigation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,8 @@ Ensure that the `onListSelected` callback in
`lib/screens/contact_groups.dart` is implemented as follows:

```dart title="lib/screens/contact_groups.dart"
import 'package:rolodex/screens/contacts.dart';
Copy link
Copy Markdown
Contributor

@johnpryan johnpryan Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is needed? Something doesn't seem right here, the rolodex package on pub.dev is not what we want (it's old and out of date), and the Rolodex project we were working on is no longer maintained.


class ContactGroupsPage extends StatelessWidget {
const ContactGroupsPage({super.key});

Expand Down Expand Up @@ -237,6 +239,17 @@ The app automatically chooses the
appropriate navigation pattern based on screen size.
This provides an optimal experience on both phones and tablets.

:::note
If you resize the app from a small screen to a large screen while on
a contact detail page, and then press the back button,
you might see a `Hero` tag exception.
This happens because the `Navigator` still holds the pushed small-screen
route while the large-screen layout simultaneously renders the detail view,
causing duplicate widgets (like the navigation bar) in the widget tree during transition.
This is an expected edge case for this simple architecture and can be ignored
for the purpose of this learning pathway.
:::

### Review


Expand Down
Loading