Skip to content

Fix viewer selection sync at max assets#760

Open
LittleJamie wants to merge 1 commit into
fluttercandies:mainfrom
LittleJamie:fix/viewer-selection-sync-live-photo
Open

Fix viewer selection sync at max assets#760
LittleJamie wants to merge 1 commit into
fluttercandies:mainfrom
LittleJamie:fix/viewer-selection-sync-live-photo

Conversation

@LittleJamie

Copy link
Copy Markdown

Summary

  • Fix picker/viewer selection syncing when selecting the last allowed asset from the preview viewer.
  • Prevent viewer selection lists from adding assets beyond maxAssets.
  • Guard Live Photo visibility callbacks so they do not update video state after the widget is disposed.

Tests

  • fvm flutter test test/delegates_test.dart
  • fvm flutter test test/providers_test.dart
  • fvm flutter analyze
  • fvm flutter test

@AlexV525

Copy link
Copy Markdown
Member

Thanks! The change looks good, however you seem to be submitting this with a different email compared to your account and it's not properly signed. Could you correct it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants