feat(share_plus): Eligible to share files with specific application via package name#3531
Closed
chandrabezzo wants to merge 8 commits intofluttercommunity:mainfrom
Closed
feat(share_plus): Eligible to share files with specific application via package name#3531chandrabezzo wants to merge 8 commits intofluttercommunity:mainfrom
chandrabezzo wants to merge 8 commits intofluttercommunity:mainfrom
Conversation
…cific-package # Conflicts: # packages/share_plus/share_plus/android/src/main/kotlin/dev/fluttercommunity/plus/share/MethodCallHandler.kt # packages/share_plus/share_plus/example/lib/main.dart # packages/share_plus/share_plus/example/pubspec.yaml # packages/share_plus/share_plus/pubspec.yaml # packages/share_plus/share_plus_platform_interface/lib/method_channel/method_channel_share.dart
chandrabezzo
changed the title
Member
|
This is quite a large PR, and it is not following the contributor guidelines (e.g. you are modifying changelogs, pubspec, etc.) unfortunately also this is not compatible with the upcoming refactor of share_plus (which I should work on someday). |
Author
|
Ok, I have created ticket #3541 @miquelbeltran |
Author
|
In the future, I think better to set request changes first instead of directly close the pull request. So, I can changes following your guideline @miquelbeltran. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Now, we can share to specific package name with fill package name of the destination app.
Checklist
CHANGELOG.mdnor the plugin version inpubspec.yamlfiles.flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!in the title as explained in Conventional Commits).