fix(device_info_plus): guard iOS vision selector#3832
Open
andyzhshg wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an iOS crash in
device_info_pluswhen collecting iOS device info on some iOS 26.1 runtimes.Crash signature:
The existing implementation guarded the call with
@available(iOS 26.1, *), but availability only confirms that the SDK/runtime version is new enough. It does not guarantee that the concreteNSProcessInfoinstance responds to the Objective-C selector. In the crash above the object is_NSSwiftProcessInfo, and sendingisiOSAppOnVisiondirectly can raise an unrecognized selector exception.This change keeps the default value as
falseand only invokesisiOSAppOnVisionafter verifying that theNSProcessInfoinstance responds to the selector. It also adds a focused regression test for the native source guard so this crash path does not get reintroduced accidentally.Verification run for the affected package:
Related Issues
No existing upstream issue was found for this specific
isiOSAppOnVisioncrash signature.Checklist
CHANGELOG.mdnor the plugin version inpubspec.yamlfiles.flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
!in the title as explained in Conventional Commits).