Skip to content

Metric gauge for status not updated when canary deleted #1029

@ta924

Description

@ta924

When evaluating the metrics endpoint after a canary is deleted, I still see metrics emitted for the previous status. The canary is successfully removed from the controller collection, but it would be beneficial when reporting on active canaries to be able to rule out deleted/terminated canaries. Would an addition of a fourth value in the gauge be acceptable when the DeleteFunc is invoked?

0 - running, 1 - successful, 2 - failed, 3 - terminated

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/enhancementImprovement request for an existing feature

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions