List valid mesh providers in help and chart values#1875
Merged
aryan9600 merged 1 commit intofluxcd:mainfrom Apr 16, 2026
Merged
List valid mesh providers in help and chart values#1875aryan9600 merged 1 commit intofluxcd:mainfrom
aryan9600 merged 1 commit intofluxcd:mainfrom
Conversation
the list of values was incomplete in the cli help, the flagger chart, and was not present as an enum in the CRD Signed-off-by: Mara Furland <mara@fur.land>
mtfurlan
force-pushed
the
doc/meshProviderValues
branch
from
445d1e9 to
959562e
Compare
aryan9600
approved these changes
Mar 8, 2026
Member
aryan9600
left a comment
aryan9600
left a comment
There was a problem hiding this comment.
lgtm, thanks for the contribution!
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1875 +/- ##
==========================================
- Coverage 39.44% 30.01% -9.43%
==========================================
Files 287 287
Lines 22706 18460 -4246
==========================================
- Hits 8956 5541 -3415
+ Misses 12777 12188 -589
+ Partials 973 731 -242 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the list of values was incomplete
Signed-off-by: Mara Furland mara@fur.land